Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPIO: Implement common traits #2664

Closed
playfulFence opened this issue Dec 2, 2024 · 0 comments · Fixed by #2842
Closed

GPIO: Implement common traits #2664

playfulFence opened this issue Dec 2, 2024 · 0 comments · Fixed by #2842
Assignees
Labels

Comments

@playfulFence
Copy link
Contributor

From esp-hal API Guidelines:

  • Where the guidelines suggest implementing Debug, defmt::Format should also be implemented
    • Event, WakeEvent, GpioRegisterAccess, all the structs (screenshot attached below).
      From Rust APU Guidelines:
      C-COMMON-TRAITS ("to be implemented" are listed):
  • enum GpioRegisterAccess: defmt::Format, Debug, Eq, PartialEq
  • enum Event, WakeEvent: Debug, Eq and PartialEq (questionable),
  • all the structs
    image

Of course, that can still be discussed!

#2492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants