serial_interrupts example ( multiple definition of interrupt )

[morteza-norouzi]

I'm just checking esp-hal examples but in "serial_interrupt" when I add UART0 ISR I'll get below error : ( what should I do ? )

= note: /home/morteza/.espressif/tools/xtensa-esp32s3-elf/esp-2021r2-patch5-8_4_0/xtensa-esp32s3-elf/bin/../lib/gcc/xtensa-esp32s3-elf/8.4.0/../../../../xtensa-esp32s3-elf/bin/ld: /home/morteza/test_esp_hal/checking-esp-hal/target/xtensa-esp32s3-none-elf/debug/deps/libesp_hal_common-8d7b594dd7a4dcd4.rlib(esp_hal_common-8d7b594dd7a4dcd4.esp_hal_common.d3fca580-cgu.14.rcgu.o): in function `__level_5_interrupt':
          /home/morteza/.cargo/registry/src/github.com-1ecc6299db9ec823/esp-hal-common-0.4.0/src/interrupt/xtensa.rs:549: multiple definition of `__level_5_interrupt'; /home/morteza/test_esp_hal/checking-esp-hal/target/xtensa-esp32s3-none-elf/debug/deps/checking_esp_hal-b2ef4af878b798b9.34o24shgg16l5yk2.rcgu.o:/home/morteza/test_esp_hal/checking-esp-hal/src/main.rs:99: first defined here
          /home/morteza/test_esp_hal/checking-esp-hal/target/xtensa-esp32s3-none-elf/debug/deps/libxtensa_lx_rt-766ed118e33c6b51.rlib(xtensa_lx_rt-766ed118e33c6b51.xtensa_lx_rt.c55cbfce-cgu.7.rcgu.o): in function `__default_naked_level_5_interrupt':
          /home/morteza/.cargo/registry/src/github.com-1ecc6299db9ec823/xtensa-lx-rt-0.14.0/src/exception/assembly_esp32.rs:632:(.rwtext+0x3c3): dangerous relocation: call4: call target out of range: __level_5_interrupt
          collect2: error: ld returned 1 exit status

main.zip

[MabezDev]

The #[interrupt] macro should be the hal macro, not xtensa-lx-rt one, this is the low level one which is already registered internally in the hal. See the example: https://github.com/esp-rs/esp-hal/blob/main/esp32s3-hal/examples/serial_interrupts.rs#L75

[morteza-norouzi]

yes but it won't be known for compiler without xtensa-lx-rt .If i just write #[interrupt] I'll get the following error :

error[E0433]: failed to resolve: unresolved import
  --> src/main.rs:99:1
   |
99 | #[interrupt]
   | ^^^^^^^^^^^^
   | |
   | unresolved import
   | help: a similar path exists: `esp32s3_hal::pac`
   |
   = note: this error originates in the attribute macro `interrupt` (in Nightly builds, run with -Z macro-backtrace for more info)

from where should i brought this macro to my project ? ( why is this so hard here ? withing c and something like stm32 or any other cortex-m it was just a weak function by default for ISR then we should rewrite that and use but here ,It's so complicated .)
I just want to have ISR handling by my self for UART but it seems there is mysterious things here !

[MabezDev]

Ensure this line is included in your imports:

esp-hal/esp32s3-hal/examples/serial_interrupts.rs

Line 14 in 7f8a15c

peripherals::{self, Peripherals, UART0},

We have an issue tracking this confusing part : #macro

[morteza-norouzi]

use esp32s3_hal::{clock::ClockControl,interrupt,peripherals::{self, Peripherals, UART0},

I can't use this code it has following error :

error[E0432]: unresolved imports `esp32s3_hal::peripherals`, `esp32s3_hal::peripherals`, `esp32s3_hal::Uart`
  --> src/main.rs:16:5
   |
16 |     peripherals::{self, Peripherals, UART0},
   |     ^^^^^^^^^^^   ^^^^ no `peripherals` in the root
   |     |
   |     could not find `peripherals` in `esp32s3_hal`
...
21 |     Uart,
   |     ^^^^ no `Uart` in the root

Instead of that I brought Uart from here :
esp32s3_hal::{clock::ClockControl, pac::{Peripherals,UART0}, prelude::*,
and my code got compile ( till #[interrupt] ) .
Am i doing this wrong ? did I forget something ?

[jessebraham]

As of the latest release you use esp32c3_hal::pac::*, however in the current main we have made some changes and you use esp32_hal::peripherals::* instead. We hope to publish new releases soon, just waiting on a few more issues to be closed.