From 28e935a27d07af9b81bf4034ef1b050e7697cecd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1niel=20Buga?= Date: Mon, 3 Feb 2025 11:38:03 +0100 Subject: [PATCH] Remove set_priority (#3088) --- esp-hal/CHANGELOG.md | 1 + esp-hal/src/dma/gdma.rs | 9 --------- esp-hal/src/dma/mod.rs | 4 ---- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/esp-hal/CHANGELOG.md b/esp-hal/CHANGELOG.md index 0a73d1d8b76..b43cbf688a5 100644 --- a/esp-hal/CHANGELOG.md +++ b/esp-hal/CHANGELOG.md @@ -46,6 +46,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Removed `Pin`, `RtcPin` and `RtcPinWithResistors` implementations from `Flex` (#2938) - OutputOpenDrain has been removed (#3029) - The fields of config structs are no longer public (#3011) +- Removed the dysfunctional `DmaChannel::set_priority` function (#3088) ## [0.23.1] - 2025-01-15 diff --git a/esp-hal/src/dma/gdma.rs b/esp-hal/src/dma/gdma.rs index 1c59bacfb60..ea05bb307c9 100644 --- a/esp-hal/src/dma/gdma.rs +++ b/esp-hal/src/dma/gdma.rs @@ -42,11 +42,6 @@ impl DmaChannel for AnyGdmaChannel { type Rx = AnyGdmaRxChannel; type Tx = AnyGdmaTxChannel; - fn set_priority(&self, priority: DmaPriority) { - AnyGdmaRxChannel(self.0).set_priority(priority); - AnyGdmaTxChannel(self.0).set_priority(priority); - } - unsafe fn split_internal(self, _: crate::private::Internal) -> (Self::Rx, Self::Tx) { (AnyGdmaRxChannel(self.0), AnyGdmaTxChannel(self.0)) } @@ -676,10 +671,6 @@ macro_rules! impl_channel { type Rx = AnyGdmaRxChannel; type Tx = AnyGdmaTxChannel; - fn set_priority(&self, priority: DmaPriority) { - AnyGdmaChannel($num).set_priority(priority); - } - unsafe fn split_internal(self, _: $crate::private::Internal) -> (Self::Rx, Self::Tx) { (AnyGdmaRxChannel($num), AnyGdmaTxChannel($num)) } diff --git a/esp-hal/src/dma/mod.rs b/esp-hal/src/dma/mod.rs index 6a18878a19d..b13f253f9e6 100644 --- a/esp-hal/src/dma/mod.rs +++ b/esp-hal/src/dma/mod.rs @@ -1618,10 +1618,6 @@ pub trait DmaChannel: Peripheral

{ /// A description of the TX half of a DMA Channel. type Tx: DmaTxChannel; - /// Sets the priority of the DMA channel. - #[cfg(gdma)] - fn set_priority(&self, priority: DmaPriority); - /// Splits the DMA channel into its RX and TX halves. #[cfg(any(esp32c6, esp32h2, esp32s3))] // TODO relax this to allow splitting on all chips fn split(self) -> (Self::Rx, Self::Tx) {