Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React StrictMode causes warnings #368

Open
davegravy opened this issue Feb 12, 2019 · 1 comment
Open

React StrictMode causes warnings #368

davegravy opened this issue Feb 12, 2019 · 1 comment
Labels
🕷️ bug

Comments

@davegravy
Copy link

🐛Bug report

Describe the bug
Warnings reported when using React StrictMode

To Reproduce
Steps to reproduce the behavior:

  1. Wrap ChartRow, TimeAxis, and YAxis components in <React.StrictMode>
  2. See warnings:

componentWillMount: Please update the following components to use componentDidMount instead: ChartRow

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: ChartRow, TimeAxis, YAxis

Expected behavior
No warnings

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 71.0.3578.98
@dirkdevriendt
Copy link

FYI / for reference: similar issue + PR that solves it in the react-vis repository
uber/react-vis#1253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕷️ bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dirkdevriendt @sartaj10 @davegravy