Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unsupported-features/node-builtins-modules #257

Merged
merged 4 commits into from
Apr 30, 2024
Merged

fix: unsupported-features/node-builtins-modules #257

merged 4 commits into from
Apr 30, 2024

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Apr 28, 2024 •
edited
Loading

fixes #250

@aladdin-add aladdin-add marked this pull request as draft April 28, 2024 19:25
@aladdin-add aladdin-add requested a review from scagood April 28, 2024 19:28
@scagood
Copy link

scagood commented Apr 28, 2024

I like this approach!

@aladdin-add aladdin-add marked this pull request as ready for review April 30, 2024 02:41
@aladdin-add aladdin-add requested a review from scagood April 30, 2024 02:41
scagood
scagood approved these changes Apr 30, 2024
View reviewed changes
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😊

Lets hope there are no more "hidden features" inside semver 😁

tests/lib/rules/no-unsupported-features/es-builtins.js Show resolved Hide resolved
@aladdin-add aladdin-add merged commit 5c67787 into master Apr 30, 2024
19 checks passed
@aladdin-add aladdin-add deleted the issue250 branch April 30, 2024 06:42
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Merged
@lholmquist lholmquist mentioned this pull request May 21, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Merged
@junsulee junsulee mentioned this pull request Jun 25, 2024
Open
This was referenced Jun 27, 2024
Closed
Closed
@lholmquist lholmquist mentioned this pull request Jul 5, 2024
Closed
This was referenced Aug 2, 2024
Closed
Closed
This was referenced Aug 13, 2024
Closed
Closed
Open
@lholmquist lholmquist mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scagood scagood scagood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: unsupported-features/node-builtins-modules doesn't work for semver range in v17
2 participants
@aladdin-add @scagood