Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to provide custom TCP options #173

Open
mentels opened this issue Apr 4, 2018 · 1 comment
Open

Make it possible to provide custom TCP options #173

mentels opened this issue Apr 4, 2018 · 1 comment

Comments

@mentels
Copy link
Contributor

mentels commented Apr 4, 2018

Such work has already been made in:

However I see a few issues here:

  • we allow to set the mode: {mode, Mode :: binary | list} - but this is wrong as escalus expect the received data to be binary (e.g. the calls erlang:byte_size/1 on it here
  • if would say the same is for active
  • we disable Nagle's algorithm by default {nodelay, true} but have we measured it helps us?
  • we set {reuseaddr, true} but we already know that setting this to true prevents us from squeezing ~50K users from one Amoc node

IMO that is to be fixed.

cc @erszcz, @michalwski @bszaf

@mentels
Copy link
Contributor Author

mentels commented Apr 4, 2018

OK, nodelay has been there in the first place so I guess someone had measured that is helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant