Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thiserror instead of failure #10

Open
tekjar opened this issue Jun 12, 2021 · 1 comment
Open

Use thiserror instead of failure #10

tekjar opened this issue Jun 12, 2021 · 1 comment

Comments

@tekjar
Copy link

tekjar commented Jun 12, 2021

thiserror implements std::error::Error so that users don't have to depend on failure crate externally or this library doesn't have to re-export failure crate.

Another reason is thiserror has become a defacto crate for error handling in rust and hence might provide better interoperability with other crates

I'll send a PR if this sounds good to you

@escwdev
Copy link
Owner

escwdev commented Jun 13, 2021

Sure that would be great @tekjar.

I've actually switched to thiserror on some other partial wrappers that I've written for other exchanges more recently I just haven't had time to prioritize changing it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants