You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the directions for creating a custom backend (which I am doing) say the following:
Create a new class which inherits from video_encoding.backends.base.BaseEncodingBackend. ...
If you want to open source your backend, follow these steps.
create a packages named django-video-encoding-BACKENDNAME
publish your package to pypi
Submit a pull requests with the following changes:
add the package to extra_requires
provide reasonable defaults for VIDEO_ENCODING_FORMATS
Won't this cause a circular dependency between this package and any additional backends? Wouldn't it be better to have the backend base (and probably subsequent backends) in a separate package?
The text was updated successfully, but these errors were encountered:
the new backend would be published as a separate package, the only thing that should be part of the PR is the optionalextra_requires dependency, which will only be installed if someone explicitly says so and adding reasonable defaults for VIDEO_ENCODING_FORMATS doesn't hurt as it is only used, when the other backend is installed and used :)
To sum up. No there shouldn't be a circular dependency, but if we figure there is one. We can fix it together :)
Currently the directions for creating a custom backend (which I am doing) say the following:
Won't this cause a circular dependency between this package and any additional backends? Wouldn't it be better to have the backend base (and probably subsequent backends) in a separate package?
The text was updated successfully, but these errors were encountered: