Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency with backends? #34

Open
RobRoseKnows opened this issue May 21, 2021 · 1 comment
Open

Circular dependency with backends? #34

RobRoseKnows opened this issue May 21, 2021 · 1 comment

Comments

@RobRoseKnows
Copy link

Currently the directions for creating a custom backend (which I am doing) say the following:

Create a new class which inherits from video_encoding.backends.base.BaseEncodingBackend. ...
If you want to open source your backend, follow these steps.

create a packages named django-video-encoding-BACKENDNAME

publish your package to pypi

Submit a pull requests with the following changes:

add the package to extra_requires
provide reasonable defaults for VIDEO_ENCODING_FORMATS

Won't this cause a circular dependency between this package and any additional backends? Wouldn't it be better to have the backend base (and probably subsequent backends) in a separate package?

@escaped
Copy link
Owner

escaped commented Oct 29, 2021

Hi @RobRoseKnows ,

the new backend would be published as a separate package, the only thing that should be part of the PR is the optional extra_requires dependency, which will only be installed if someone explicitly says so and adding reasonable defaults for VIDEO_ENCODING_FORMATS doesn't hurt as it is only used, when the other backend is installed and used :)

To sum up. No there shouldn't be a circular dependency, but if we figure there is one. We can fix it together :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants