ci: use node 12 (#46)

Author: privatenumber

.github/workflows/test.yml

@@ -9,6 +9,7 @@ jobs:
     name: Test
     runs-on: ubuntu-latest
     timeout-minutes: 10
+
     steps:
     - name: Checkout
       uses: actions/checkout@v3
@@ -19,8 +20,9 @@ jobs:
         node-version-file: '.nvmrc'
 
     - name: Setup pnpm
-      uses: pnpm/action-setup@v2
+      uses: pnpm/action-setup@v2.4.0
       with:
+        standalone: true
         version: 8
         run_install: true
 
@@ -30,5 +32,16 @@ jobs:
     - name: Type check
       run: pnpm type-check
 
+    - name: Build
+      run: pnpm build
+
     - name: Test
       run: pnpm test
+
+    - name: Use Node.js 12
+      uses: actions/setup-node@v3
+      with:
+        node-version: '12'
+
+    - name: Test with Node v12
+      run: pnpm test

package.json

@@ -30,7 +30,7 @@
 		"build": "pkgroll --target node12.20 --minify",
 		"lint": "eslint --cache .",
 		"type-check": "tsc --noEmit",
-		"test": "pnpm build && tsx --no-cache tests",
+		"test": "tsx --no-cache tests",
 		"dev": "tsx watch --no-cache --conditions=development tests",
 		"prepack": "pnpm build && clean-pkg-json"
 	},

tests/specs/source-maps.ts

@@ -1,17 +1,20 @@
 import { spawnSync } from 'child_process';
 import path from 'path';
+import { promises as fs } from 'fs';
 import { testSuite, expect } from 'manten';
 import { createFixture } from 'fs-fixture';
 import {
 	transformSync,
 	installSourceMapSupport,
 } from '#esbuild-kit/core-utils';
 
+const isNode12 = process.version.startsWith('v12.');
+
 const applySourceMap = installSourceMapSupport();
 
 export default testSuite(({ describe }) => {
 	describe('source map', ({ test }) => {
-		test('sourcemap file', async () => {
+		test('sourcemap file', async ({ onTestFinish }) => {
 			const rawFile = 'raw.js';
 			const code = 'let nameInError;\n\n\n    nameInError();';
 			const transformedFile = 'transformed.mts';
@@ -26,16 +29,27 @@ export default testSuite(({ describe }) => {
 				[transformedFile]: applySourceMap(transformed, ''),
 			});
 
+			onTestFinish(async () => {
+				if (isNode12) {
+					await fs.rmdir(fixture.path, {
+						recursive: true,
+					});
+				} else {
+					await fixture.rm();
+				}
+			});
+
 			const expected = spawnSync(process.execPath, [path.join(fixture.path, rawFile)]);
 			const received = spawnSync(process.execPath, ['--enable-source-maps', path.join(fixture.path, transformedFile)]);
 
-			await fixture.rm();
-
 			const stderrReceived = received.stderr.toString();
 			expect(stderrReceived).toMatch('nameInError');
 
-			const errorPosition = expected.stderr.toString().match(new RegExp(`${rawFile}(:\\d+:\\d+)`));
-			expect(stderrReceived).toMatch(transformedFile + errorPosition![1]);
+			// Node 12 doesn't support native source maps
+			if (!isNode12) {
+				const errorPosition = expected.stderr.toString().match(new RegExp(`${rawFile}(:\\d+:\\d+)`));
+				expect(stderrReceived).toMatch(transformedFile + errorPosition![1]);
+			}
 		});
 
 		test('path is same for windows', async () => {