Minor refactorings

Author: bzurkowski

src/mas.erl

@@ -24,7 +24,8 @@ start() ->
 %%------------------------------------------------------------------------------
 %% @doc Starts simulation with provided simulation parameters. Simulation
 %%      terminates automaticaly if given time constraint is a positive integer.
-%%      Otherwise simulation runs infinitely.
+%%      Otherwise simulation runs infinitely. MAS engine is able to process
+%%      only one simulation at once.
 %% @end
 %%------------------------------------------------------------------------------
 start_simulation(SP, Time) ->

src/mas_population.erl

@@ -92,9 +92,8 @@ handle_cast(_Msg, State) ->
 %% @private
 %%------------------------------------------------------------------------------
 handle_info(process_population, State) ->
-    NewState = process_population(State),
     self() ! process_population,
-    {noreply, NewState};
+    {noreply, process_population(State)};
 handle_info(update_metrics, State = #state{config = Config}) ->
     schedule_metrics_update(Config),
     {noreply, update_metrics(State)};

src/mas_simulation.erl

@@ -54,8 +54,7 @@ start_link(Config) ->
 %%------------------------------------------------------------------------------
 %% @doc Starts simulation with provided simulation parameters. Simulation
 %%      terminates automaticaly if given time constraint is a positive integer.
-%%      Otherwise simulation runs infinitely. MAS engine is able to process
-%%      only one simulation at once.
+%%      Otherwise simulation runs infinitely.
 %% @end
 %%------------------------------------------------------------------------------
 start_simulation(SP, Time) ->

src/mas_world.erl

@@ -73,8 +73,7 @@ init(#config{population_count = Count, topology = Topology}) ->
 %% @private
 %%------------------------------------------------------------------------------
 handle_call(get_agents, _From, State = #state{populations = Populations}) ->
-    Agents = collect_agents(Populations),
-    {reply, {agents, Agents}, State};
+    {reply, {agents, collect_agents(Populations)}, State};
 handle_call(_Request, _From, State) ->
     {reply, ignored, State}.
 
@@ -97,8 +96,7 @@ handle_cast(_Msg, State) ->
 %% @private
 %%------------------------------------------------------------------------------
 handle_info(spawn_populations, State = #state{population_count = Count}) ->
-    Populations = spawn_populations(Count),
-    {noreply, State#state{populations = Populations}};
+    {noreply, State#state{populations = spawn_populations(Count)}};
 handle_info(_Info, State) ->
     {noreply, State}.