Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating an instance with a collection string array doesnt work #40

Open
FuelKubitox opened this issue Mar 18, 2021 · 0 comments
Open

Comments

@FuelKubitox
Copy link

FuelKubitox commented Mar 18, 2021

I wanted to create an instance of zangodb and passed the database name and a string array with the collections, but in my code he wants then a version parameter.

I saw in your db.js file on line 55 that you only check if the second parameter is an object and not if its an string array, so you definitly need a version parameter, when you pass only a string array with the collections.

Update: But i noticed that i have to pass a version parameter anyway, because i use Typescript. But dont know if it is intended with the missing type check in your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant