Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set of optionally allowed expression types in no-top-level-variables configuration #1115

Open
ericcornelissen opened this issue Aug 4, 2024 · 1 comment
Labels
breaking change Changes that are not backwards compatible pending This cannot be worked on yet

Comments

@ericcornelissen
Copy link
Owner

ericcornelissen commented Aug 4, 2024

Relates to #1107

Summary

The YieldExpression value for the allowed option of the no-top-level-variables is useless because yield is not allowed at the top level - hence it should be removed.

However, it can't just be removed because that's a breaking change because it would reject any existing configuration that does explicitly allow it.

Change description

To close this issue the ImportExpression, SequenceExpression, ThisExpression, and YieldExpression should be removed from the allowedOption.enum list.

@ericcornelissen ericcornelissen added pending This cannot be worked on yet breaking change Changes that are not backwards compatible labels Aug 4, 2024
@ericcornelissen
Copy link
Owner Author

Following #1166, this issue also goes for ImportExpression, SequenceExpression, and ThisExpression but instead because they're now in the list of always allowed expressions.

@ericcornelissen ericcornelissen changed the title Remove YieldExpression from no-top-level-variables configuration Update set of optionally allowed expression types in no-top-level-variables configuration Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that are not backwards compatible pending This cannot be worked on yet
Projects
None yet
Development

No branches or pull requests

1 participant