Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max_rows on PI requests #6

Open
einarsi opened this issue May 27, 2020 · 1 comment
Open

Reduce max_rows on PI requests #6

einarsi opened this issue May 27, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@einarsi
Copy link
Collaborator

einarsi commented May 27, 2020

Issue added on GitLab by @knudsvik 2018-06-12:

Based on experience, 100.000 rows got a time-out.

@einarsi
Copy link
Collaborator Author

einarsi commented May 27, 2020

Proposed solution: Wrap parts of _read_single_tag() in a try-except-clause where we try to fetch data n times until we report a failure and die. max_rows gets automatically reduced (halved?) on each attempt with feedback to user so he/she can adjust manually next time. Also let max_rows be parameter to IMSClient creation.

Until then, set max_rows manually:

c = IMSClient('myserver', 'pi')
c.handler.max_rows = 50000

@einarsi einarsi added the bug Something isn't working label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant