Move mypy typing check to pre-commit hooks (#151)

* move mypy typing check to pre-commit hooks to avoid having the _version.py file
* merge typing.yml and lint.yml to a unique precommit.yml and run it on every commit
* change precommit.yml triggering to both push and pull_request
* add some args for mypy: --ignore-missing-imports, --no-warn-unused-ignores

Author: antoinecollet5

.github/workflows/lint.yml renamed to .github/workflows/precommit.yml

@@ -1,6 +1,6 @@
-name: Lint
+name: Pre-commit tests
 
-on: [pull_request]
+on: [push, pull_request]
 
 jobs:
   lint:
@@ -15,5 +15,5 @@ jobs:
       - name: Install tox
         run: pip install tox
 
-      - name: Check style
-        run: tox -e style
+      - name: Check precommit
+        run: tox -e precommit

.github/workflows/typing.yml

@@ -11,3 +11,14 @@ repos:
     rev: 22.6.0
     hooks:
     - id: black
+
+-   repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.5.1
+    hooks:
+    -   id: mypy
+        exclude: |
+            (?x)(
+                ^tests/|
+                ^docs
+            )
+        args: [--strict, --ignore-missing-imports, --no-warn-unused-ignores]

.pre-commit-config.yaml

@@ -4,16 +4,12 @@
 https://www.frontiersin.org/articles/10.3389/fams.2019.00047/full
 """
 try:
-    from ._version import version as __version__
+    from ._version import version as __version__  # type: ignore
     from ._version import version_tuple
 except ImportError:
     __version__ = "unknown version"
     version_tuple = (0, 0, "unknown version", "unknown commit")
-
-from iterative_ensemble_smoother._iterative_ensemble_smoother import (
-    ES,
-    SIES,
-)
+from iterative_ensemble_smoother._iterative_ensemble_smoother import ES, SIES
 from iterative_ensemble_smoother.esmda import ESMDA
 
 __all__ = [

src/iterative_ensemble_smoother/__init__.py

@@ -13,7 +13,7 @@ commands =
     pytest tests/
     pytest src/ --doctest-modules
 
-[testenv:style]
+[testenv:precommit]
 deps = pre-commit
 skip_install = true
 commands = pre-commit run --all-files --show-diff-on-failure
@@ -25,12 +25,6 @@ commands =
     python -m ipykernel install --user
     sphinx-build -c docs/source/ -b html docs/source/ docs/build/html -W
 
-[testenv:typing]
-deps =
-    .[dev]
-skip_install = true
-commands = mypy --strict src/iterative_ensemble_smoother
-
 [pytest]
 addopts =
     -ra