Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using pybind11 in favour of Boost.Python #42

Open
sindre-nistad opened this issue Jan 12, 2024 · 1 comment
Open

Consider using pybind11 in favour of Boost.Python #42

sindre-nistad opened this issue Jan 12, 2024 · 1 comment

Comments

@sindre-nistad
Copy link
Collaborator

pybind11 seem to be able to do what we are currently using Boost.Python for today.

Some of the reasons in favour of migrating

  • Boost is overkill for our purposes
  • compiling it, as part of the compilation of the wheels, has been a source of a few problems
  • the abridged source code for Boost takes a significant part of our source distribution (~36 MB uncompressed)
  • cmake/boost.cmake contributes quite a bit to the complexity of compiling gaussianfft
  • The vast majority of what Boost has to offer is not used in our case

Some reasons against migrating

  • Currently, the compilation, and everything else works as expected
@oddvarlia
Copy link
Collaborator

When using pybind11 instead of boost we avoid the issue which arise when boost version in RMS and boost version in gaussianfft are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants