Improve roles

[KaterynaBasik]

Currently there are following roles in Flyt

• Owner (Default role for the one who creates the process initially, can share write access to others)
• Admin (can share write access to others)
• Contributor

User input 1 (by Fredrik Liknes, feedback ID 235 ):
As a contributor I would like to be able to share write access to a VSM without requesting the owner to add new contributors.

[nesadrian]

We have previously discussed if we should remove owner altogether and only have admin and contributor roles since owner and admin has the same privileges anyways. The idea of everyone having the same role has also been brought up before. This would solve #247 and since Flyt is limited to Equinor users anyways, removing these accesses might not be a big concern.

[askbulle]

All three roles should be combined into role "Collaborator" and that role should be able to both write and share write access.

[askbulle]

If Quick fix priority should be high. If not, re-assess prio

[srvEq]

Hi @askbulle
As discussed three roles(Owner, Admin, Contributor) will combine into "Collaborator" role will have the both write and share write access.

Does "Collaborator" role also have the privilege to delete the Process?

[askbulle]

Yes, Collaborator should have all access that Owner and Admin has.

Can we have a look at the message ? It seems that when some text is bolded more people actually see it.

[askbulle]

Suggested text:

Are you sure you want to delete this process? By doing so you will delete ALL VERSIONS as they will not be recoverable.

[srvEq]

Changes deployed in Test env.
@AnjaliPandit20 @SIJAIEQUINOR @rvaidya3007

[srvEq]

Ready to test the below changes in Test env.

• All three roles [owner, admin, contributor] combined into one role that is "Contributor" where Contributor has write, share the write access and delete the process.
• Updated confirmation message of delete process with "Are you sure you want to delete this process? By doing so you will delete ALL VERSIONS as they will not be recoverable."
• Removed Owner section from the dropdown of the process, attached reference below for the same

@luan-droid @SIVN1 @ThomasBracho1987
CC: @sarsi0801

[SIVN1]

@srvEq @sarsi0801 Verified in Test environment. We have found below three issues.

Issue 1. "Delete process" is not enabled for old processes. So, we are not able to delete the old processes

Issue 2. New Functionality scenario : After created a process, I didn't add any one as a contributor for that process. But I removed my name from contributor list, then who will delete that process?

New Functionality screenshot:

In the old functionality scenario- If I created any process, I added as an Owner, So I can't remove myself from the list. Here I can delete my process at any time

Old Functionality screenshot:

Issue 3: This Contributor changes are applicable only for new processes. Regarding this I had a discussion with Sri, She has mentioned that they will clean up the data base.
Our opinion on deleting the data in DB:

If we delete the data from DB, User might loss all the process they have created before. So, is there any possibility to create duplicate for old processes and make this contributor changes applicable for old processes as well ?

CC: @AnjaliPandit20 @rvaidya3007 @ThomasBracho1987 @luan-droid @SIJAIEQUINOR

[srvEq]

Issue1, Issue3 both happens because of existing data where it has roles as admin, owner, contributor. It will work fine once existing data is handled.

My suggestion is to do the data cleanse which refers to change all the existing roles in DB to contributor, so there won't be any data loss.

The above issues has to be addressed from Backend.
@sarsi0801 Can you please review the above issue.

Issue 2
Thanks for the finding, When only one user has access to a process then we can disable/restrict the user from providing the option to remove.Does this sound good ?

@SIVN1 @luan-droid @ThomasBracho1987 @jsundarn

[sarsi0801]

@srvEq @SIVN1 I will change the existing roles in DB to contributor for few old process then i will test above issue, if it works fien then i will update roles to contributor for all old process. This will resolve Issue 1 and 3.

[SIVN1]

@srvEq We can go with the solution which you have provided for Issue 2. Thank you

CC: @AnjaliPandit20 @luan-droid @ThomasBracho1987 @jsundarn @rvaidya3007

[sarsi0801]

@srvEq
I have updated the role for all old process to contributor.
You can test the Issue1 and Issue3.

[luan-droid]

Issue 1: I can now delete my old processes, it works fine.

Issue 3: I can see now that the role is changed from "Owner" to "Contributor". It works fine.

@srvEq @sarsi0801 @SIVN1 @ThomasBracho1987

[srvEq]

Issue 2 is fixed and deployed in test env.
@SIVN1 @luan-droid @ThomasBracho1987

[SIVN1]

@srvEq @sarsi0801 Verified issue 2 and adding same name again issue in Test. It works fine

CC: @AnjaliPandit20 @ThomasBracho1987 @luan-droid @SIJAIEQUINOR @rvaidya3007

[srvEq]

Changes deployed in QA. @sarsi0801 is looking into DB changes.

[sarsi0801]

DB changes are done in QA environment.

[srvEq]

Ready to test the changes in QA environment.
@SIVN1 @luan-droid @ThomasBracho1987

[luan-droid]

It works fine, but the pop up window for renaming looks weird

[srvEq]

The above issue will be tracked in #884. Hence closing this.
@luan-droid @SIVN1 @ThomasBracho1987
CC: @AnjaliPandit20 @SIJAIEQUINOR @rvaidya3007

[srvEq]

@sarsi0801 FE changes deployed in Test and QA

[srvEq]

Changes are ready to test in both Test and QA env.
@SIVN1 @luan-droid @ThomasBracho1987

[luan-droid]

Tested in QA and Test, works fine.

• All three roles should be combined into role "Collaborator" and that role should be able to both write and share write access