Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧱 Export subcomponents individually for ssr support #3725

Merged
merged 3 commits into from
Feb 18, 2025
Merged

🧱 Export subcomponents individually for ssr support #3725

merged 3 commits into from
Feb 18, 2025

Conversation

oddvernes
Copy link
Collaborator

resolves #3723

@oddvernes
Copy link
Collaborator Author

oddvernes commented Feb 3, 2025 •
edited
Loading

A note: we have discovered that while this works for static components such as Card, it does not work with some components with internal post-processing of children (ReactChildren.map/cloneElement), such as Menu and Accordion

Edit, never mind this was a mistake by the tester not using required sub-components, everything actually seems to work

sebastianvitterso
sebastianvitterso approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@sebastianvitterso sebastianvitterso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and after testing, it works well too.

@oddvernes oddvernes merged commit 22f0744 into develop Feb 18, 2025
6 checks passed
@oddvernes oddvernes deleted the OOVE/3723-export-subcomponents-for-ssr branch February 18, 2025 14:18
@sebastianvitterso
Copy link
Contributor

Nice! Now we're just eagerly awaiting a new release 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianvitterso sebastianvitterso sebastianvitterso approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@torleifhalseth torleifhalseth Awaiting requested review from torleifhalseth torleifhalseth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨Add support for composite components in nextjs
2 participants
@oddvernes @sebastianvitterso