Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ETH and STRK fee token addresses configurable #2453

Closed
kkovaacs opened this issue Dec 20, 2024 · 1 comment · Fixed by #2477
Closed

Make ETH and STRK fee token addresses configurable #2453

kkovaacs opened this issue Dec 20, 2024 · 1 comment · Fixed by #2477
Assignees
Labels
enhancement New feature or request

Comments

@kkovaacs
Copy link
Contributor

There are custom Starknet chains where the fee token addresses diverge from the addresses used on the public Starknet integration/testnet/mainnet networks.

This issue leads to blockifier failing balance checks when executing transactions -- because the fee token address is not even deployed, we're basically reading a balance of zero for any contract address.

We should make the ETH and STRK fee token addresses configurable for at least the custom network use case.

@kkovaacs kkovaacs added the enhancement New feature or request label Dec 20, 2024
@kkovaacs kkovaacs added this to the Starknet 0.13.4 milestone Jan 8, 2025
@kkovaacs
Copy link
Contributor Author

kkovaacs commented Jan 8, 2025

Starknet 0.13.4 has made token addresses available on the get_contract_addresses endpoint of the feeder gateway:

{
  "FriStatementContract": "0x55d049b4C82807808E76e61a08C6764bbf2ffB55",
  "GpsStatementVerifier": "0x2046B966994Adcb88D83f467a41b75d64C2a619F",
  "MemoryPageFactRegistry": "0x5628E75245Cc69eCA0994F0449F4dDA9FbB5Ec6a",
  "MerkleStatementContract": "0xd414f8f535D4a96cB00fFC8E85160b353cb7809c",
  "Starknet": "0x4737c0c1B4D5b1A687B42610DdabEE781152359c",
  "strk_l2_token_address": "0x4718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d",
  "eth_l2_token_address": "0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants