Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StorageIndex newtype #2332

Open
sistemd opened this issue Oct 23, 2024 · 5 comments
Open

Add StorageIndex newtype #2332

sistemd opened this issue Oct 23, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@sistemd
Copy link
Contributor

sistemd commented Oct 23, 2024

In our database, every trie node has a unique storage index. We simply represent this as a u64 in the code. The code would be a bit clearer and a bit less error prone if we had a simple newtype for it.
@sistemd sistemd self-assigned this Oct 23, 2024
@sistemd sistemd assigned sistemd and unassigned sistemd Oct 31, 2024
@sistemd sistemd added the good first issue Good for newcomers label Nov 12, 2024
@sistemd sistemd removed their assignment Nov 12, 2024
@varun-doshi
Copy link

I can take this up if its still open

@0xdevcollins
Copy link

May I pick this up?

@varun-doshi varun-doshi mentioned this issue Dec 2, 2024
Open
@mimisavage
Copy link

Could I be assigned to this?

@vbar
Copy link
Contributor

vbar commented Dec 13, 2024

Could I be assigned to this?

It's already being implemented, in #2428 .

@aidenwong812
Copy link

Can I take care of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vbar @sistemd @varun-doshi @0xdevcollins @aidenwong812 @mimisavage