Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: implement SerializeForVersion for RPC v0.6 #2047

Open
2 tasks
Mirko-von-Leipzig opened this issue May 30, 2024 · 0 comments
Open
2 tasks

RPC: implement SerializeForVersion for RPC v0.6 #2047

Mirko-von-Leipzig opened this issue May 30, 2024 · 0 comments

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Requires #1830.

Once #1830 is completed, all methods should be available for use which enables switching to using these for all RPC versions.

I propose only doing this once RPC version v0.4 and v0.5 have been removed. This (a) lessens the work, and (b) is safer since some methods have changed semantically (and have different error types for example).

This leaves RPC v0.6:

  • Implement existing DTO changes in the serialization code by diffing RPC v0.6 and v0.7 of the specification.
  • Switch all v0.6 methods to the crates/rpc/method/ implementations
    • [ Ensure the DTO changes defined within each method itself are also implemented (these DTOs are specified within the method implementation itself).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants