Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider how to uniformise value for base_url across low-level parsers #63

Open
Bisaloo opened this issue Nov 23, 2023 · 0 comments
Open

Consider how to uniformise value for base_url across low-level parsers #63

Bisaloo opened this issue Nov 23, 2023 · 0 comments

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Nov 23, 2023

Part of #53

Follow up from the discussion in #62 (comment)

I can see how a potential user would be confused about the fact they sometimes have to pass "example.com" and sometimes "https://example.com/" to base_url, even though I understand the underlying technical reason.

Couple of pathways:

  • always use just the hostname and internally add https://
  • always use the URL and internally strip https://
  • always accept both
  • accept the inconsistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bisaloo