-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to epidemic_size()
#212
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e99365a is merged into main:
|
44e4316
to
dacc084
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e99365a is merged into main:
|
3f2d068
to
7ee37fb
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 21ebc61 is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @pratikunterwegs. The enhancements provide more flexibility to the user. It all LGTM. I left some comments, where I thought some changes could be made to your own satisfaction.
Thanks @jamesmbaazam, will address these and merge later today. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 21ebc61 is merged into main:
|
This PR addresses issues raised in #190:
epidemic_size()
now optionally returns a<data.table>
of epidemic sizes at specified timepoints via the logicalsimplify
argument; the default behaviour remains returning a numeric vector (for backwards compatibility);stage
;simplify
argument, if a vector is passed tostage
ortime
.