-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camp population changes for diphtheria model #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this included. I've made a few edits to the vignette for clarity.
Also wondered: is the current lack of vaccination a technical obstacle in the model (i.e. not possible with current modular structure)? Or just omitted for simplicity?
Finally, I get a lot of non-essential CPP warnings when installing the package from branch. Do we suppress these for users in end package (as probably won't add much value for majority of users, and may make them wonder if something is wrong)?
Thanks for taking a look @adamkucharski - will accept your edits and merge shortly.
For simplicity really, following the scenario described in the paper. It's definitely possible to add a vaccination compartment if necessary. We did hear at MSF Manson that they might be interested in modelling for vaccination advocacy in camps, so happy to work along those lines if you have any input.
We do not, admittedly, as the suppress warnings flag |
Co-authored-by: Adam Kucharski <[email protected]>
This PR:
population_change
mechanic, which is passed as a named list of times and values of changes to each demographic group at those times. This functionality could be expanded to other models in future if needed.population_changes
C++ struct in thepopulation
namespace, with a member function to check for any current changes; also updates relevant header and source files for the diphtheria model;