Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor observation filtering (trunaction) functions #34

Open
athowes opened this issue May 14, 2024 · 1 comment
Open

Refactor observation filtering (trunaction) functions #34

athowes opened this issue May 14, 2024 · 1 comment
Assignees

Comments

@athowes
Copy link
Collaborator

athowes commented May 14, 2024

In line with the filter_obs_by_ptime() function, I think it would be more descriptive and clear to have the filter_obs_by_obs_time() function be called filter_obs_by_stime(): filter observations by the time of the secondary observation.

Perhaps there is a question as to whether we want to be implementing "simple" operations like this, but if we are then I think the rename is a good idea.

@athowes athowes changed the title Rename filter_obs_by_obs_time to filter_obs_by_stime Refactor observation filtering (trunaction) functions May 15, 2024
@athowes
Copy link
Collaborator Author

athowes commented May 15, 2024

As a part of this issue, I propose to:

  • standardise the filter_obs_by_obs_time and filter_obs_by_ptime functions (perhaps could be merged into one function with an argument for p or s),
  • create unit tests for these two functions, and
  • fill out the roxygen2 documentation for these two functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant