This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Degree of freedom for variance calculation #31
Comments
|
Any updates for this issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I found that np.var function is used to calculate the variances in the code. Since the np.var function is using
ddof=0by default, we need to fix it to useddof=1to make all the equations aligned with the original paper.I created a PR for it. Please take a look and let me know if you have any thoughts.
PR link: #30
The text was updated successfully, but these errors were encountered: