-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if some required packages could be made suggested #434
Comments
Hi Richard, Firstly sorry for the lack of response here recently been very busy on another project and neglected everything else. Will get up to speed on the work you have been doing over the next few days and try and make some useful contributions. For this issue, I agree limiting imports is a really good idea. My preferred solution would be yes to go with suggests and allow then a check for the package with a message about what is needed to be installed. Auto-installing would make CRAN not happy I think and introducing code work arounnds might just make it harder to code things (though if possible could be useful). |
I think this rule of < 20 dependencies is counterproductive. I predicted people will just start depending on big meta-packages (like tidyverse) instead of smaller, more focused packages. I suggest we do something like this (but not as hacky): many functions of the tidyverse are re-exported in many places and we can import them in a clever way to minimise dependencies. For example, I can submit a PR for this later this week. |
If you can figure out why we're getting CMD check failures in |
This was changed in the development version of rlang: r-lib/rlang@aa587b0#diff-e4299ca7439da3d937d0a2b7b28e948378c040e1c337911055dbddf60af08e5c so it's probably just a mismatch between your local version and the version on GitHub Actions. I don't think this was intended to be a re-export anyways so I removed it in d3c150b. |
Working through the new Colombia data (#432 and #433) we started getting a warning about importing too many packages. For packages which are only necessary for a few ("few" not yet defined) specific datasets, we could make these suggested imports instead of required and box around them, either:
This will first require looking at which files are using which imported functions and identify which may be candidates for pruning. Suggestions on tools to do this smoothly would be welcome!
The text was updated successfully, but these errors were encountered: