Fix segmentation fault when trying to save invalid long strings #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-ess
force-pushed
the
fix_segfault
branch
from
b248355
to
f26a19b
Compare
|
I'd recommend testing this change against the lsi & lso (long string in/out) record types too, they provide access to the VAL field slightly differently than a waveform record although I doubt the code would need to be any different for them. Using these types instead of a CHAR waveform makes the database designer's intention clearer when they're available (since Base 3.15). |
This can occur if you have something like the following:
```
record(waveform, "foo") {
field(FTVL, "CHAR")
field(NELM, "10")
info(autosaveFields, "VAL VAL$")
}
```
The `VAL$` field will cause a segmentation fault when it tries to
save it to disk. The reason this seems to happen is that on one hand,
`VAL$` is regarded by autosave as a valid field (it is a field, but
with a `$` at the end). On the other hand, when connecting a monitor,
the connection fails as the `VAL` field is not of the correcct type
as defined in `dbChannelCreate` from EPICS base.
This means that autosave will try to save the date from an unconnected
array, with uninitialised pArray, causing a segmentation fault.
simon-ess
force-pushed
the
fix_segfault
branch
from
f26a19b
to
b8bfdc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur if you have something like the following:
The
VAL$field will cause a segmentation fault when it tries to save it to disk. The reason this seems to happen is that on one hand,VAL$is regarded by autosave as a valid field (it is a field, but with a$at the end). On the other hand, when connecting a monitor, the connection fails as theVALfield is not of the correcct type as defined indbChannelCreatefrom EPICS base.This means that autosave will try to save the date from an unconnected array, with uninitialised pArray, causing a segmentation fault.
Fixes #59