Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe we can get rid of some dependencies or minify the footprint #3914

Open
asvae opened this issue Sep 27, 2023 · 3 comments
Open

Maybe we can get rid of some dependencies or minify the footprint #3914

asvae opened this issue Sep 27, 2023 · 3 comments
Assignees

Comments

@asvae
Copy link
Member

asvae commented Sep 27, 2023

Users generally want the less dependencies the better, so I suggest we try to minimize dependency footprint.

  • Vue has capitalize (maybe something else), so we probably can use that instead of lodash, as we definitely need vue.
  • colortranslator - we have very limited use
  • cleave - would be nice to have as a peer dependency
  • vue-validate would be nice to have as peer dependency

Current libs (see npm):

@m0ksem
Copy link
Collaborator

m0ksem commented Oct 18, 2023

lodash also can be removed, even though it tree-shakable, we have functions like capilatize in vue package. All we actually need is camelCase and kebabCase which are easy to implement.

@jonjakoblich
Copy link

jonjakoblich commented Jan 28, 2024

I second removing Cleave.js. The package has not been updated for almost 4 years, and the maintainer announced in November that he will not be doing any more work on it. Cleave-zen might be a good alternative or there might be another.

@m0ksem
Copy link
Collaborator

m0ksem commented Apr 3, 2024

@kushich, we'll need to remove cleave, but make an integration with external solution. Cleave-zen can be a solution or we can find something else.

colortranslator can be easily removed.

floating ui is super useful, let's keep it. As well as lodash and @types/lodash.

We also need a way to integrate our form with vee-validate or/and vuelidate.

I'm not sure how to help people when they ask about how masks works rn and where to find example or docs. Cleave.js is kind of hard and ugly.

An external validation library provides rules, so we don't need to make our own. As I know, there is no easy way to integrate external validation into vuestic right now. Currently, I satisfied with current validation mechanism we provide with vuestic, but there is a thirst for better solutions.

I'd split this issue in multiple tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants