Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: The scale of structures in "Select Attachment Points" Modal is too big #3923

Open
olganaz opened this issue Jan 17, 2024 · 2 comments · May be fixed by #4059
Open

Macro: The scale of structures in "Select Attachment Points" Modal is too big #3923

olganaz opened this issue Jan 17, 2024 · 2 comments · May be fixed by #4059
Assignees
@StarlaStarla
Labels
bug Common UI problems Bucket: Common UI problems
Milestone
Refined Backlog

Comments

@olganaz
Copy link
Collaborator

olganaz commented Jan 17, 2024 •
edited by rrodionov91
Loading

Steps to Reproduce

  1. Open Ketcher Macromolecules
  2. Add Base 'nC6n8A' (6-Aminohexyl-8-aminoadenine) on canvas
  3. Add peptide monomer 'G' (Glycine) on canvas
  4. Drag the bond between two monomers "center-to-center"
  5. Click on the 'Expand' icon in "Select Attachment Points" Modal

Actual behavior
Modal window is expanded.
The structure of Glycine scaled up too much.

Expected behavior
Modal window is expanded.
The scale of structure in preview should not be larger than 100% (how it looks on canvas).
#3580

Additional context
The same behavior was also observed for CHEMS: SMPEG2, sDBL, SS3 and some other monomers with large structure
Peptide monomer 'G' (Glycine) was taken as an example of monomer with small structure and two APs.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10 pro
  • Browser: Google Chrome
  • Version: 120.0.6099.130 (Official Build) (64-bit)

Ketcher version
Version 2.18.0-rc.2
Build at 2024-01-17; 15:03:49
@olganaz olganaz added the bug label Jan 17, 2024
@olganaz olganaz added this to the Ketcher 2.18.0-rc.3 milestone Jan 17, 2024
@Zhirnoff
Copy link
Collaborator

Test added to the automation table.

@Konstantin1996 Konstantin1996 self-assigned this Jan 23, 2024
@rrodionov91 rrodionov91 changed the title Macro: The scale of two structures in expanded "Select Attachment Points" Modal is not the same Macro: The scale of structures in "Select Attachment Points" Modal is ещщ ишп Jan 29, 2024
@rrodionov91 rrodionov91 changed the title Macro: The scale of structures in "Select Attachment Points" Modal is ещщ ишп Macro: The scale of structures in "Select Attachment Points" Modal is too big Jan 29, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Jan 30, 2024
StarlaStarla added a commit that referenced this issue Feb 8, 2024
@StarlaStarla
#3923 The scale of structures in "Select Attachment Points" Modal is …
9532851 
…too big
@StarlaStarla StarlaStarla linked a pull request Feb 8, 2024 that will close this issue
Macro: #3923 - The scale of structures in "Select Attachment Points" Modal is too big #4059
Open
9 tasks
StarlaStarla added a commit that referenced this issue Feb 9, 2024
@StarlaStarla
#3923 refactor and rename
c31322a
StarlaStarla added a commit that referenced this issue Feb 9, 2024
@StarlaStarla
#3923 fix screenshots
a15e5f2
@AlexeyGirin AlexeyGirin removed this from the Ketcher 2.20.0-rc.1 milestone Mar 14, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.20.0-rc.2 milestone Mar 14, 2024
@AlexeyGirin AlexeyGirin added the Common UI problems Bucket: Common UI problems label Apr 17, 2024
@AlexeyGirin
Copy link
Collaborator

Moved to Refined Backlog since no fix over 3 versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug Common UI problems Bucket: Common UI problems
Projects
None yet
Milestone
Refined Backlog
Development

Successfully merging a pull request may close this issue.

Macro: #3923 - The scale of structures in "Select Attachment Points" Modal is too big epam/ketcher
7 participants
@rrodionov91 @AlexeyGirin @Konstantin1996 @StarlaStarla @Zhirnoff @olganaz @ilya-asiyuk-epam