Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve core config validation #203

Open
adubovik opened this issue Feb 12, 2024 · 0 comments
Open

Improve core config validation #203

adubovik opened this issue Feb 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@adubovik
Copy link
Contributor

Currently there are a lot of arbitrary parsed JSON strings in the Core config schema.

We need to make the schema more strict, to fail fast in case of incorrect configs.

A couple of examples:

  1. Pricing.unit is of type String, whereas it must be enum with "tokens" and "char_without_whitespace" cases;
  2. Deployment.name is of type String, whereas it must be a string matching pattern [^/]+ (see ControllerSelector);
  3. Deployment.iconUrl is String, whereas it must a be a valid URL.

And many more...

@adubovik adubovik added the enhancement New feature or request label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant