Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): change chat and marketplace buttons placement (Issue #2641) #2660

Merged
merged 14 commits into from
Nov 26, 2024
Merged

feat(chat): change chat and marketplace buttons placement (Issue #2641) #2660

merged 14 commits into from
Nov 26, 2024

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Nov 25, 2024 •
edited
Loading

Description:

Show "New conversation"(Chat) and "Back to Chat"(Marketplace) buttons in header on all devices

Issues:

UI changes

Снимок экрана 2024-11-25 в 11 59 09 Снимок экрана 2024-11-25 в 11 59 39

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Derikyan Derikyan added the enhancement New feature or request label Nov 25, 2024
@Derikyan Derikyan self-assigned this Nov 25, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

1 similar comment
@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

@nartovm
Copy link
Contributor

nartovm commented Nov 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

@nartovm
Copy link
Contributor

nartovm commented Nov 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

irinakartun
irinakartun previously approved these changes Nov 25, 2024
View reviewed changes
@nartovm
Copy link
Contributor

nartovm commented Nov 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

@nartovm
Copy link
Contributor

nartovm commented Nov 25, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

Tests are considered to be passed, there are 3 failed tests due to the known problem, investigation is in progress

nartovm
nartovm previously approved these changes Nov 26, 2024
View reviewed changes
irinakartun
irinakartun previously approved these changes Nov 26, 2024
View reviewed changes
@Derikyan Derikyan dismissed stale reviews from irinakartun and nartovm via d544c9a November 26, 2024 10:08
@Derikyan Derikyan enabled auto-merge (squash) November 26, 2024 10:33
@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 26, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2660.nightly-test.deltixhub.io
E2E tests status: failed

@Derikyan Derikyan merged commit 35967af into development Nov 26, 2024
8 checks passed
@Derikyan Derikyan deleted the feat/2641-chat-and-marketplace-header-buttons branch November 26, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaBondar IlyaBondar IlyaBondar approved these changes

@irinakartun irinakartun irinakartun approved these changes

@nartovm nartovm nartovm left review comments

@Gimir Gimir Awaiting requested review from Gimir Gimir is a code owner

@denys-kolomiitsev denys-kolomiitsev Awaiting requested review from denys-kolomiitsev denys-kolomiitsev is a code owner

@Alexander-Kezik Alexander-Kezik Awaiting requested review from Alexander-Kezik Alexander-Kezik is a code owner

@likeamike likeamike Awaiting requested review from likeamike likeamike is a code owner

Assignees

@Derikyan Derikyan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Derikyan @nartovm @irinakartun @IlyaBondar