Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Fix infinite loader, add error handling for the multiple conversations upload (Issue #1596) #2629

Merged
merged 11 commits into from
Nov 20, 2024

Conversation

denys-kolomiitsev
Copy link
Contributor

@denys-kolomiitsev denys-kolomiitsev commented Nov 18, 2024

Description:

Fix infinite loader, add error handling multiple conversations upload.

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@denys-kolomiitsev denys-kolomiitsev self-assigned this Nov 18, 2024
@denys-kolomiitsev denys-kolomiitsev changed the title fix(chat): fix add error handling (Issue #1596) fix(chat): Fix infinite loader, add error handling (Issue #1596) Nov 18, 2024
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 18, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2629.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 18, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2629.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 19, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2629.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev denys-kolomiitsev changed the title fix(chat): Fix infinite loader, add error handling (Issue #1596) fix(chat): Fix infinite loader, add error handling for the multiple conversations upload (Issue #1596) Nov 19, 2024
@Alexander-Kezik
Copy link
Contributor

Alexander-Kezik commented Nov 19, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2629.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 19, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2629.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev denys-kolomiitsev merged commit bcb2d78 into development Nov 20, 2024
8 checks passed
@denys-kolomiitsev denys-kolomiitsev deleted the fix/1596-shared-error-after-revoke branch November 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants