Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text]: Possibility to remove paddings, align with Figma #2639

Open
DzmitryTrubchyk opened this issue Nov 15, 2024 · 1 comment
Open

[Text]: Possibility to remove paddings, align with Figma #2639

DzmitryTrubchyk opened this issue Nov 15, 2024 · 1 comment
Labels
Design <> Dev align Issues related to component Figma React alignment feature New feature or request

Comments

@DzmitryTrubchyk
Copy link
Collaborator

image

@DzmitryTrubchyk DzmitryTrubchyk added the feature New feature or request label Nov 15, 2024
@DzmitryTrubchyk DzmitryTrubchyk changed the title Text component: Remove paddings Text component: Remove paddings, align with Figma Nov 15, 2024
@DzmitryTrubchyk DzmitryTrubchyk added the Design <> Dev align Issues related to component Figma React alignment label Nov 15, 2024
@AlekseyManetov
Copy link
Collaborator

AlekseyManetov commented Dec 9, 2024

We cannot remove the padding by default from the Text component because it would be a major breaking change. Additionally, it doesn't quite align with the current purpose of the component, as it was intended to fit into a grid according to the given size props. For example, a 36 text should be 36px in height and align with other components like buttons or text inputs.

First and foremost, we need to decide on the future of the Text component and define its use cases. After that, we can make a decision on how to modify it.

@AlekseyManetov AlekseyManetov changed the title Text component: Remove paddings, align with Figma [Text]: Possibility to remove paddings, align with Figma Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design <> Dev align Issues related to component Figma React alignment feature New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants