Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2217

Closed
AnnaKosol opened this issue Aug 12, 2024 · 2 comments · Fixed by #2547 or #2546
Closed

The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2217

AnnaKosol opened this issue Aug 12, 2024 · 2 comments · Fixed by #2547 or #2546
Assignees
@AliaksandrDziarkach
Labels
Bug Export to CDX Bucket: Bugs related to Export to CDX Export to CDXML Bucket: Bugs related to Export to CDXML Priority: High Team G
Milestone
Indigo-1.25.0-rc.3

Comments

@AnnaKosol
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add file
    4 mol.ket.zip
    or create manually
Снимок экрана 2024-08-09 в 14 34 37
  1. save to CDX (or CDXML, base64 cdx) format
  2. open saving file on the canvas

Expected behavior
Reaction should be loaded without changing order of components

Actual behavior
The retrosynthetic arrows are pointing in the other direction.
Снимок экрана 2024-08-12 в 13 17 43

Environment details:
Ketcher Version 2.23.0-rc.3 Build at 2024-08-08; 13:17:49
Indigo Version 1.24.0-dev.1.0-g5561a82a1-wasm32-wasm-clang-19.0.0
Chrome Версия 126.0.6478.127 (Официальная сборка), (arm64)
MacOs Sonoma 14.5

Issue found while testing #2071
@AnnaKosol AnnaKosol added Export to CDXML Bucket: Bugs related to Export to CDXML Export to CDX Bucket: Bugs related to Export to CDX labels Aug 16, 2024
@AnnaKosol AnnaKosol added this to the Indigo-1.24.0-rc.2 milestone Sep 5, 2024
@AnnaKosol AnnaKosol changed the title Preview: the wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows Sep 10, 2024
AliaksandrDziarkach added a commit that referenced this issue Oct 10, 2024
@AliaksandrDziarkach
#2217 The wrong direction of the arrows when exporting from CDXML (o…
01f1d75 
…r CDX, base64 cdx) format and two retrosynthetic arrows

Fix code. Add UT
AliaksandrDziarkach added a commit that referenced this issue Oct 10, 2024
@AliaksandrDziarkach
Backmerge: #2217 - The wrong direction of the arrows when exporting f…
88480de 
…rom CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows

backmerge to master
This was linked to pull requests Oct 10, 2024
Backmerge: #2217 - The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2547
Merged
#2217 - The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2546
Merged
AlexanderSavelyev pushed a commit that referenced this issue Oct 11, 2024
@AliaksandrDziarkach
#2217 - The wrong direction of the arrows when exporting from CDXML …
3965eb7 
…(or CDX, base64 cdx) format and two retrosynthetic arrows (#2546)
AlexanderSavelyev pushed a commit that referenced this issue Oct 11, 2024
@AliaksandrDziarkach
Backmerge: #2217 - The wrong direction of the arrows when exporting f…
d18ef55 
…rom CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows (#2547)
@AlexeyGirin AlexeyGirin reopened this Oct 15, 2024
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 15, 2024 •
edited
Loading

Not fixed.
Throws exception once you try to save to CDX: Convert error! array: invalid index 2 (size=2)
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

@AlexeyGirin AlexeyGirin mentioned this issue Oct 16, 2024
Closed
@AlexeyGirin
Copy link
Collaborator

Verified. Follow up bug created: #2558
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Export to CDX Bucket: Bugs related to Export to CDX Export to CDXML Bucket: Bugs related to Export to CDXML Priority: High Team G
Projects
None yet
Milestone
Indigo-1.25.0-rc.3
6 participants
@rrodionov91 @AliaksandrDziarkach @AlexeyGirin @AnnaKosol @AlekseiKhariukov @AleksandrParamonoff