react-element-to-jsx-string requires react 15 :-(

[ljharb]

I'm using React 0.14, and react-element-to-jsx-string has a direct dependency (not a peer dep) on react-addons-test-utils - https://npmcdn.com/[email protected]/package.json.

This means that a normal npm install will install a 15.x version of react-addons-test-utils, which will then complain that my React 0.14 doesn't work.

react-element-to-jsx-string needs to have a peer dep on react-addons-test-utils, not a direct dep.

I'm filing this here, since this is manifesting as a bug in chai-enzyme in that npm ls doesn't work when i install it.

[ayrton]

As a workaround I believe we can loosen up the dependency to do ^2.1.0 | ^3.0.0. See this diff.

We only have one use case with react-element-to-jsx library so far.

[ayrton]

@ljharb how do you see the most ideal solution?

[ljharb]

That won't solve it, since npm will still try to install the latest.

The ideal solution is that nothing is a singleton and nothing needs peer deps :-) but React is a singleton, so all react things must only specify React things as peer deps. In other words, if I want to use chai-enzyme (with react-element-to-jsx-string as a dependency), i must install react-addons-test-utils as a top-level dep.

Another alternative is to simply remove that feature, and drop the dependency.

[ayrton]

I think it's best to pin chai-enzyme to 0.4.2, which is the latest release that doesn't pull in react-element-to-jsx-string.

As an aside react-element-to-jsx-string supports react 0.14.8 and above while we support 0.14 and above, maybe we should bump this too? thoughts? cc @vesln

[ljharb]

bumping to the latest 0.14 seems just fine