Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Warning When Validating YubiKey OTP Despite Using the Latest Version #32

Open
Julian3004 opened this issue Jun 12, 2023 · 6 comments

Comments

@Julian3004
Copy link

When validating a YubiKey OTP using the latest version of the software, I encountered an error. When providing an incorrect OTP value, I receive the following deprecated warning:

Deprecated: Creation of dynamic property Yubikey\Validate::$clientId is deprecated in /Users/Shared/www/inc/vendor/enygma/yubikey/src/Yubikey/Validate.php on line 145.

This error occurs even though I previously passed the correct Secret Code and API Code that I obtained beforehand.

Steps to Reproduce:

  1. Use the latest version of the software.
    
  2. Generate an invalid YubiKey OTP.
    
  3. Pass the OTP value to the validation process.
    
  4. Observe the deprecated warning that occurs.
    

Expected Behavior:
The software should correctly identify the error and provide a meaningful error message instead of generating a deprecated warning.

Additional Information:

  • Operating System: MAC OS - Ventura 13.4
    
  • Software Version: 13.4
    
@mbolli
Copy link
Contributor

mbolli commented Sep 26, 2023

It should work with dev-master, although it would be nice if @enygma could publish a release

@enygma
Copy link
Owner

enygma commented Sep 26, 2023

@Julian3004 @mbolli New release just pushed - let me know if that helps things.

@mbolli
Copy link
Contributor

mbolli commented Sep 26, 2023

Seems to work with PHP 8.2 - thanks for the quick reaction!

@mbolli
Copy link
Contributor

mbolli commented Nov 29, 2023

Actually the deprecated warning mentioned here is only solved with merging #34. Also note that there is another deprecation which is fixed in #33.

@enygma
Copy link
Owner

enygma commented Nov 29, 2023

Merged that other PR and made a new release (3.5)

@mbolli
Copy link
Contributor

mbolli commented Dec 6, 2023

I just saw that you missed #34 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants