Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Font Family src with ? Throws Exception #580

Open
2 tasks done
HeyITGuyFixIt opened this issue Feb 11, 2019 · 1 comment
Open
2 tasks done

CSS Font Family src with ? Throws Exception #580

HeyITGuyFixIt opened this issue Feb 11, 2019 · 1 comment
Assignees
Labels

Comments

@HeyITGuyFixIt
Copy link

HeyITGuyFixIt commented Feb 11, 2019

  • I Am on Linux
    • Debian

Description

I have a font-family that uses ?s in its src URLs. Apparently this results in a liquid exception being thrown because of jekyll-assets or liquid-tag-parser.

Steps

This is the code that I am using:

@font-face {
    font-family: 'fontello';
    src: url(asset_path("'fontello/fontello.eot?89493118'"));
    src: url(asset_path("'fontello/fontello.eot?89493118#iefix'")) format("embedded-opentype"), asset_url("'fontello/fontello.woff2?89493118'") format("woff2"), asset_url("'fontello/fontello.woff?89493118'") format("woff"), asset_url("'fontello/fontello.ttf?89493118'") format("truetype"), asset_url("'fontello/fontello.svg?89493118#fontello'") format("svg");
    font-weight: normal;
    font-style: normal;
}

Output

Whenever I build it using the latest of everything I get this Liquid Exception.

Liquid Exception: Liquid error (line 7): Unmatched double quote: "'fontello/fontello.woff2 \\@path" in /_layouts/default.html
bundler: failed to load command: jekyll (/usr/local/bundle/bin/jekyll)
Liquid::ArgumentError: Liquid error (line 7): Unmatched double quote: "'fontello/fontello.woff2  \\@path"

Expected

I am expecting it to retrieve the fonts correctly with the question marks.

@envygeeks
Copy link
Owner

This is definitely a pretty severe bug, I thought this was fixed, I'll double check.

@envygeeks envygeeks self-assigned this Feb 11, 2019
@envygeeks envygeeks added the bug label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants