Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split HTTP and TCP/UDP access log format in EnvoyProxy #3695

Open
aoledk opened this issue Jun 28, 2024 · 4 comments
Open

Split HTTP and TCP/UDP access log format in EnvoyProxy #3695

aoledk opened this issue Jun 28, 2024 · 4 comments

Comments

@aoledk
Copy link
Contributor

aoledk commented Jun 28, 2024

Description:

HTTP and TCP/UDP don't have same command operators, REQ and RESP operators only in HTTP is important for observability. If operators only in HTTP is configured for TCP/UDP, - will be placed in related access log operator.

If user wants to deploy HTTP and TCP/UDP listeners under same GatewayClass with mergeGateways enabled, user can't attach EnvoyProxy to Gateway to let different Gateway use their own access log format, then TCP/UDP will have massive - in access log, it's unnecessary overhead and produce useless info to access log.

As a workaround, user can choose to split HTTP and TCP/UDP to different GatewayClass with their own necessary access log format.

Maybe we can consider allow user to configure access log format for HTTP and TCP/UDP separately in EnvoyProxy.

[optional Relevant Links:]

https://gateway.envoyproxy.io/v1.0.2/api/extension_types/#proxyaccesslogsetting
https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/access_log/usage#command-operators

@aoledk aoledk added the triage label Jun 28, 2024
@arkodg
Copy link
Contributor

arkodg commented Jun 28, 2024

imo this is a presentation problem, can this be solved using the new CEL matches option ?
#3688

@zirain
Copy link
Contributor

zirain commented Jun 29, 2024

#3688 won't help, but I don't think this's critical, at end the accesslog will be store in system like loki, share same json struct.

@aoledk
Copy link
Contributor Author

aoledk commented Jun 30, 2024

It's not critical issue indeed and will not cause any problems in envoy, all it affects is in the end Loki maybe store massive - char because TCP/UDP listener don't support HTTP-only operator, especially REQ and RESP.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants