-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ratelimit Domain should use Gateway class instead of Listener #3678
Comments
@nezdolik i'm curious why this is happening, im trying to better understand the collision The IR Listener name has the gateway/internal/gatewayapi/helpers.go Line 360 in d784c32
and I dont think 1 Gateway can be mapped to multiple GatewayClass parents, so unsure whats happening here |
okay found the problem, the ratelimit runner is treating every subscribed message as SoTW
but the publisher / gateway-api runner is sending individual messages per gatewayclass
|
the ratelimit runner will need to perform some additional accounting similar to what gateway-api runner does
|
/assign |
Opened a patch PR: #3771 |
Description:
EG currently uses Listener as domain for Ratelimit service config. It should instead use Gateway class not to override RL config for a case when when multiple Envoy deployments with diff gateway classes use same RL instance.
Repro steps:
Environment:
Logs:
The text was updated successfully, but these errors were encountered: