From 9dc28619d3cb3954ab7ffa8bcb4bf6b037ca10d6 Mon Sep 17 00:00:00 2001 From: Isaac <10012479+jukie@users.noreply.github.com> Date: Thu, 4 Dec 2025 11:17:29 -0700 Subject: [PATCH] [bp/1.36] Set envoy_reloadable_features_http2_use_oghttp2=false by default (#42319) Risk Level: Testing: Yes Docs Changes: No Release Notes: Changes the default value of envoy.reloadable_features.http2_use_oghttp2 to false. This changes the codec used for HTTP/2 requests and responses. Once issue 40070 is resolved this will be re-enabled in a future version. Platform Specific Features: xRef: https://github.com/envoyproxy/envoy/issues/40070 --------- Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> Signed-off-by: Isaac <10012479+jukie@users.noreply.github.com> --- source/common/runtime/runtime_features.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/common/runtime/runtime_features.cc b/source/common/runtime/runtime_features.cc index d3e28e1be27b4..b778ca7af3d01 100644 --- a/source/common/runtime/runtime_features.cc +++ b/source/common/runtime/runtime_features.cc @@ -50,7 +50,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_balsa_disallow_lone_cr_in_chunk_ex RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header); RUNTIME_GUARD(envoy_reloadable_features_http2_include_cookies_in_limits); RUNTIME_GUARD(envoy_reloadable_features_http2_propagate_reset_events); -RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); RUNTIME_GUARD(envoy_reloadable_features_http3_remove_empty_cookie); // Delay deprecation and decommission until UHV is enabled. RUNTIME_GUARD(envoy_reloadable_features_http_reject_path_with_fragment); @@ -216,6 +215,9 @@ FALSE_RUNTIME_GUARD(envoy_reloadable_features_fixed_heap_use_allocated); // TODO(yavlasov): Enabling by default will be hugely disruptive to existing traffic. // Replace with a config option (default off) post CVE release. FALSE_RUNTIME_GUARD(envoy_reloadable_features_reject_early_connect_data); +// Flip back to true once performance aligns with nghttp2 and +// https://github.com/envoyproxy/envoy/issues/40070 is resolved. +FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); // Enable histograms of HTTP/2 header sizes, including cookie size. FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_record_histograms);