Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_disable_starlark_host_transitions will break Envoy in Bazel 7.0 #24565

Open
keertk opened this issue Dec 15, 2022 · 7 comments
Assignees
Labels
bazel no stalebot Disables stalebot from closing an issue upstream/deprecation

Comments

@keertk
Copy link

keertk commented Dec 15, 2022

Incompatible flag --incompatible_disable_starlark_host_transitions will be enabled by default in the next major release (Bazel 7.0), thus breaking Envoy. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#17032.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@keith
Copy link
Member

keith commented Dec 15, 2022

likely dependent on many upstream rules to fix theirs first given how large the list of broken ones is right now

@keith keith self-assigned this Dec 15, 2022
@keith
Copy link
Member

keith commented Dec 15, 2022

Currently it's a rules_nodejs failure breaking us:

File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/c2f35c9754a3b95e7cda1d4f26eb71d4/external/build_bazel_rules_nodejs/internal/pkg_web/pkg_web.bzl", line 37, column 29, in <toplevel>
  | "_assembler": attr.label(
  | Error in label: 'cfg = "host"' is deprecated and should no longer be used. Please use 'cfg = "exec"' instead.

@phlax phlax added bazel upstream/deprecation and removed triage Issue requires triage labels Dec 16, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 15, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2023
@sgowroji
Copy link

Hi @keith, CI failure is still exists . Can you please reopen this issue. Thanks!

@keith keith reopened this May 23, 2023
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label May 23, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 22, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
@keith keith reopened this Jul 19, 2023
keith added a commit to keith/envoy that referenced this issue Jul 19, 2023
Fixes: envoyproxy#24565

Signed-off-by: Keith Smiley <[email protected]>
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jul 20, 2023
@keith keith added the no stalebot Disables stalebot from closing an issue label Jul 20, 2023
@keith keith assigned keith and unassigned keith Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel no stalebot Disables stalebot from closing an issue upstream/deprecation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants