remove type restriction for job attach method

Prashanth Sadasivan · dboskovic · commit 1259d4fa78c7 · 2018-09-19T11:17:50.000-06:00
diff --git a/lib/response.js b/lib/response.js
@@ -46,14 +46,10 @@ Response = (function () {
   }
   Response.prototype.job_attach = function (...attachments) {
     const requiredLabels = [ 'type', 'label', 'value' ]
-    const allowedTypes = [ 'link', 'password' ]
     for (const attachment of attachments) {
       if (!~requiredLabels.every(l => ~Object.keys(attachment).indexOf(l))) {
         throw new Error(`Attachment requires mandatory properties ${requiredLabels.join(', ')}`)
       }
-      if (!~allowedTypes.indexOf(attachment.type)) {
-        throw new Error(`Attachment must be of one of the following types ${allowedTypes.join(', ')}`)
-      }
     }
     this._attachments.push(...attachments)
     this.meta('set_job_attachments', JSON.stringify(this._attachments))

Original file line number	Diff line number	Diff line change
`@@ -46,14 +46,10 @@ Response = (function () {`
`46`	`46`	`}`
`47`	`47`	`Response.prototype.job_attach = function (...attachments) {`
`48`	`48`	`const requiredLabels = [ 'type', 'label', 'value' ]`
`49`		`- const allowedTypes = [ 'link', 'password' ]`
`50`	`49`	`for (const attachment of attachments) {`
`51`	`50`	`if (!~requiredLabels.every(l => ~Object.keys(attachment).indexOf(l))) {`
`52`	`51`	throw new Error(`Attachment requires mandatory properties ${requiredLabels.join(', ')}`)
`53`	`52`	`}`
`54`		`- if (!~allowedTypes.indexOf(attachment.type)) {`
`55`		- throw new Error(`Attachment must be of one of the following types ${allowedTypes.join(', ')}`)
`56`		`- }`
`57`	`53`	`}`
`58`	`54`	`this._attachments.push(...attachments)`
`59`	`55`	`this.meta('set_job_attachments', JSON.stringify(this._attachments))`