-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No actionbar in Settings #818
Comments
Record_2021-09-17-13-33-33.mp4 |
@asaikarthikeya I am done with work, I will make PR if you approve. Thanks |
Sure, go ahead! thanks. |
i will make it tomorrow. my laptop is getting debugged(repaired) :) |
What's the thing with this issue? Would you please, provide a detailed description for the issue, in accordance to our contributing guidelines |
The back button on the top toolbar is missing in setting screen. |
Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:
Hence, we first should discuss which layout should be preferred for future releases. |
I want to contribute to this issue, I also started work on it. |
Yeah, great. Just go ahead |
Same
The same issue is there for |
Yes and no 👇
|
yes i know that sir but that activity doesnt have any toolbar |
Hello Dhiraj, Do you think a toolbar looks good in the recording screen? Toolbar is intentionally ignored in the recording screen. The back option is also not a must have feature in settings screen. Always try to think in the opposite way(how it will be if I have a toolbar, does it improve the UI?) before asking. Some things are designed intentional keeping several other parameters in mind. Thank you🙂 |
I meant the back option and not the toolbar in recording screen activity, sorry for the inconvenience. I Will sure try to think that way before asking next time. |
Is this issue still open? May I work on it? Can someone help me? |
the issue is not open for work, there is an ongoing discussion for this. |
@cdhiraj40 Is this issue still in discussion or I can work upon it ? |
The back button is missing in setting screen.
The text was updated successfully, but these errors were encountered: