Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No actionbar in Settings #818

Open
cdhiraj40 opened this issue Sep 17, 2021 · 19 comments
Open

No actionbar in Settings #818

cdhiraj40 opened this issue Sep 17, 2021 · 19 comments

Comments

@cdhiraj40
Copy link
Contributor

cdhiraj40 commented Sep 17, 2021

The back button is missing in setting screen.

Screenshot_2021-09-17-13-33-10-57_47898aacd586656d6f60f8abb18dee77.jpg

@cdhiraj40
Copy link
Contributor Author

Record_2021-09-17-13-33-33.mp4

@cdhiraj40
Copy link
Contributor Author

@asaikarthikeya I am done with work, I will make PR if you approve. Thanks

@asaikarthikeya
Copy link
Member

Sure, go ahead! thanks.

@cdhiraj40
Copy link
Contributor Author

Sure, go ahead! thanks.

i will make it tomorrow. my laptop is getting debugged(repaired) :)

@SebaDro
Copy link
Contributor

SebaDro commented Sep 23, 2021

What's the thing with this issue? Would you please, provide a detailed description for the issue, in accordance to our contributing guidelines

@asaikarthikeya
Copy link
Member

What's the thing with this issue? Would you please, provide a detailed description for the issue, in accordance to our contributing guidelines

The back button on the top toolbar is missing in setting screen.

@asaikarthikeya
Copy link
Member

@SebaDro Please refer @dewall sir's message in #427, where Dewall sir has mentioned about missing of back option in settings.

@SebaDro
Copy link
Contributor

SebaDro commented Oct 14, 2021

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

  1. enviroCar logo with back button
  2. enviroCar logo without back button
  3. text header with back button
    In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

@Jdbarad
Copy link
Contributor

Jdbarad commented Oct 27, 2021

I want to contribute to this issue, I also started work on it.

@SebaDro
Copy link
Contributor

SebaDro commented Oct 27, 2021

Yeah, great. Just go ahead

@asaikarthikeya
Copy link
Member

@Jdbarad @SebaDro This issue has been already worked and is yet to be reviewed - PR #821. Please work on a issue that doesnot have a pull request attacked to it. Thanks :)

@cdhiraj40
Copy link
Contributor Author

Same

What's the thing with this issue? Would you please, provide a detailed description for the issue, in accordance to our contributing guidelines

The back button on the top toolbar is missing in setting screen.

The same issue is there for StartRecordingActivity, any reason sir? @SebaDro @asaikarthikeya

@SebaDro
Copy link
Contributor

SebaDro commented Nov 11, 2021

Yes and no 👇

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

  1. enviroCar logo with back button
  2. enviroCar logo without back button
  3. text header with back button
    In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

@cdhiraj40
Copy link
Contributor Author

cdhiraj40 commented Nov 11, 2021

Yes and no 👇

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

  1. enviroCar logo with back button
  2. enviroCar logo without back button
  3. text header with back button
    In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

yes i know that sir but that activity doesnt have any toolbar

Screenshot_2021-11-11-20-14-57-18_47898aacd586656d6f60f8abb18dee77.jpg

Screenshot_2021-11-11-20-18-16-72_47898aacd586656d6f60f8abb18dee77.jpg

@asaikarthikeya
Copy link
Member

asaikarthikeya commented Nov 11, 2021

Yes and no 👇

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

  1. enviroCar logo with back button
  2. enviroCar logo without back button
  3. text header with back button
    In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

yes i know that sir but that activity doesnt have any toolbar

Screenshot_2021-11-11-20-14-57-18_47898aacd586656d6f60f8abb18dee77.jpg

Screenshot_2021-11-11-20-18-16-72_47898aacd586656d6f60f8abb18dee77.jpg

Hello Dhiraj, Do you think a toolbar looks good in the recording screen? Toolbar is intentionally ignored in the recording screen. The back option is also not a must have feature in settings screen. Always try to think in the opposite way(how it will be if I have a toolbar, does it improve the UI?) before asking. Some things are designed intentional keeping several other parameters in mind. Thank you🙂

@cdhiraj40
Copy link
Contributor Author

cdhiraj40 commented Nov 11, 2021

Yes and no point_down

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

  1. enviroCar logo with back button
  2. enviroCar logo without back button
  3. text header with back button
    In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

yes i know that sir but that activity doesnt have any toolbar
Screenshot_2021-11-11-20-14-57-18_47898aacd586656d6f60f8abb18dee77.jpg
Screenshot_2021-11-11-20-18-16-72_47898aacd586656d6f60f8abb18dee77.jpg

Hello Dhiraj, Do you think a toolbar looks good in the recording screen? Toolbar is intentionally ignored in the recording screen. The back option is also not a must have feature in settings screen. Always try to think in the opposite way( who it will be if I have a toolbar, does it improve the UI?) before asking. Some things are designed intentional keeping several other parameters in mind. Thank youslightly_smiling_face

I meant the back option and not the toolbar in recording screen activity, sorry for the inconvenience. I Will sure try to think that way before asking next time.

@pree-T
Copy link

pree-T commented Jan 11, 2022

Is this issue still open? May I work on it? Can someone help me?

@cdhiraj40
Copy link
Contributor Author

Is this issue still open? May I work on it? Can someone help me?

the issue is not open for work, there is an ongoing discussion for this.

@madhurmehta007
Copy link

@cdhiraj40 Is this issue still in discussion or I can work upon it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants