Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add missing Option to env0_aws_cloud_configuration (Resource) f… #1008

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Feat: Add missing Option to env0_aws_cloud_configuration (Resource) f… #1008

merged 1 commit into from
Feb 5, 2025

Conversation

TomerHeber
Copy link
Collaborator

…or "Prefix under AWSLogs folder"

Issue & Steps to Reproduce / Feature Request

resolves #1007

Solution

  1. Added missing field to the schema.
  2. Added missing field to the structs.
  3. Updated acceptance tests.
  4. Updated harness tests.

@TomerHeber TomerHeber self-assigned this Jan 30, 2025
@TomerHeber
Copy link
Collaborator Author

/review

@bot-env0 bot-env0 requested a review from a team January 30, 2025 03:39
GiliFaroEnv0
GiliFaroEnv0 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Feb 5, 2025
@liranfarage89
Copy link
Contributor

@TomerHeber Can we proceed with the merge? Discount Tire are waiting for it.

Thanks

@TomerHeber TomerHeber merged commit 8a1906d into main Feb 5, 2025
7 checks passed
@TomerHeber TomerHeber deleted the feat-add-aws-prefix-#1007 branch February 5, 2025 17:13
@TomerHeber
Copy link
Collaborator Author

@TomerHeber Can we proceed with the merge? Discount Tire are waiting for it.

Thanks

@liranfarage89 I'll release it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiliFaroEnv0 GiliFaroEnv0 GiliFaroEnv0 approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client dependency-change feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing Option to env0_aws_cloud_configuration (Resource) for "Prefix under AWSLogs folder"
3 participants
@TomerHeber @liranfarage89 @GiliFaroEnv0