Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract types should be skipped from serialization #92

Open
ComBatVision opened this issue Oct 28, 2020 · 1 comment
Open

Abstract types should be skipped from serialization #92

ComBatVision opened this issue Oct 28, 2020 · 1 comment

Comments

@ComBatVision
Copy link
Contributor

After implementation of derivationBySubsumption option all abstract types, which were replaced by its children types, remains empty (without any attributes) in the result proto files and they never used in any result messages anymore.

There should be an option like skipEmptyTypeInheritance, but for abstract types replaced by derivation, e.g. skipAbstractTypes

Or may be remove abstract types by default when derivationBySubsumption is enabled, because anyway messages without fields are useless.

@ComBatVision ComBatVision changed the title New option to skip empty abstract types is required Empty abstract types should be skipped from serialization Oct 28, 2020
@ComBatVision ComBatVision changed the title Empty abstract types should be skipped from serialization Abstract types should be skipped from serialization Nov 13, 2020
@ComBatVision
Copy link
Contributor Author

I think even abstract types which have own fields (not only empty one) should also be skipped, because they also should be replaced by derivationBySubsumption option and never used directly for data serialization.

That's why I propose to skip any type which have attribute abstract = "true" regardless of its content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant