Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the J command better #231

Open
nomeata opened this issue Nov 7, 2020 · 0 comments
Open

Handle the J command better #231

nomeata opened this issue Nov 7, 2020 · 0 comments

Comments

@nomeata
Copy link
Member

nomeata commented Nov 7, 2020 •
edited
Loading

With a6f8581 the documentation finally explains the rules around J (I hope I got them right), thanks to @SciLor to summarize them in #179 (comment).

But tttool should be smarter about them, and

  • do the right thing in tttool play (reported in Play - Implement J(x) P(y) - Protected Jump #179)
  • warn about bad patterns in tttool assemble
  • in tttool lint, check existing GME files for deviations from this rule (might be worth checking them out to see how they behave)
@nomeata nomeata mentioned this issue Nov 7, 2020
Open
tbleher pushed a commit to tbleher/tip-toi-reveng that referenced this issue Dec 1, 2020
tttool play: handle the J command correctly (entropia#231)
d006732 
The J() command is executed after all other commands in the line have
executed. Simulate this correctly.
tbleher pushed a commit to tbleher/tip-toi-reveng that referenced this issue Dec 1, 2020
tttool play: improve handling of the J command (entropia#231)
64904b4 
The J() command is executed after all other commands in the line have
executed. The 2s pause if no P() follows J() (as documented in
entropia#179 (comment))
is not implemented yet.
tbleher pushed a commit to tbleher/tip-toi-reveng that referenced this issue Dec 5, 2020
lint: verify that each line contains only one jump
002bff7 
As discussed in entropia#231 and entropia#238, TipToi pens handle a jump after all other
actions (even if they are earlier in the list). If there are multiple
jumps, only the last has an effect. This lint check verifies that a GME
only contains one jump, and that the jump is the last action. This check
is true for all GMEs published by Ravensburger.
tbleher pushed a commit to tbleher/tip-toi-reveng that referenced this issue Dec 5, 2020
lint: verify that each line contains only one jump
5ad1912 
As discussed in entropia#231 and entropia#238, TipToi pens handle a jump after all other
actions (even if they are earlier in the list). If there are multiple
jumps, only the last has an effect. This lint check verifies that a GME
only contains one jump, and that the jump is the last action. This check
is true for all GMEs published by Ravensburger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nomeata