Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Amazon Web Services does not show an icon. #3867

Closed
tur1ngb0x opened this issue Oct 28, 2024 · 4 comments
Closed

[Bug] Amazon Web Services does not show an icon. #3867

tur1ngb0x opened this issue Oct 28, 2024 · 4 comments
Labels

Comments

@tur1ngb0x
Copy link

Description

Amazon Web Services entry in the Windows Desktop app does not show an icon.

OS: Windows 10 Build 19045.4894
Client: Ente Auth v4.0.2
Service: Amazon Web Services
Issuer: aws.amazon.com
Account: aws.amazon.com

Main Page Token Options
1 2

Version

4.0.2

What product are you using?

Ente Auth

What platform are you using?

Desktop - Windows

@LeGenDaRy15PT
Copy link
Contributor

Hello @tur1ngb0x

It will probably be added in the next update, I added this icon last week.
AWS icon

@KingLuc12
Copy link
Contributor

The issue is the "Account Issuer" isn't "Amazon Web Services". aws.amazon.com has not been added as one of the "altNames".

If you set the issuer name to Amazon Web Services, then the icon should appear. I recommend someone adds "aws.amazon.com" in the list of "altNames" so that by default people will have the logo - Well at least it should work if someone did that but, altNames are currently not working as I mentioned here: #3875

TLDR: Change the issuer name to "Amazon Web Services" and it should work as expected.

@LeGenDaRy15PT
Copy link
Contributor

I actually made a python script to send the name of the images.svg to a notepad and then through that notepad I had each image name per line and as I put in several icons I configured them alphabetically by the “title” tag in “custom-icons.json” because doing it manually would take too long, so it did everything automatically using the script.

I'm still not sure how the “altNames” thing works, but if there's a problem in the future, just put the right name there if it's not recognized as it is.

imagem

I did it like this:
1- Names image per line
imagem
2- Original Code
imagem
3- Modify Code
imagem

@tur1ngb0x
Copy link
Author

tur1ngb0x commented Oct 29, 2024

The issue is the "Account Issuer" isn't "Amazon Web Services". aws.amazon.com has not been added as one of the "altNames".

If you set the issuer name to Amazon Web Services, then the icon should appear. I recommend someone adds "aws.amazon.com" in the list of "altNames" so that by default people will have the logo - Well at least it should work if someone did that but, altNames are currently not working as I mentioned here: #3875

TLDR: Change the issuer name to "Amazon Web Services" and it should work as expected.

Changing the issuer name to "Amazon Web Services" worked for now. The AWS icon is now visible.

@ua741 ua741 closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants