Testing EnsoMeta ability to load Enso types from Standard.Base #14287
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
4e6,
AdRiley,
GregoryTravis,
hubertp and
jdunkerley
as code owners
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
commented
Nov 12, 2025
| .dependsOn(`poi-wrapper`) | ||
| .dependsOn(`std-base` % "provided") | ||
|
|
||
| lazy val `std-tests` = project |
Member
Author
There was a problem hiding this comment.
@jdunkerley, it is possible to run these tests quickly:
sbt:enso> std-tests/clean
sbt:enso> std-tests/test
[info] Test run org.enso.base.polyglot.tests.EnsoMetaTest finished: 1 total, 3.595s
[info] Passed: Total 1, Failed 0, Errors 0, Passed 1
e.g. the test finished in less than four seconds (or in eleven seconds on CI).
Member
Author
There was a problem hiding this comment.
- originally I wanted to add these tests into
std-table - but there is recursive project dependency
- as
test-utilsdepend onstd-table(to have Enso distribution fully built) - and making
std-tabledepend ontest-utilswas ... complicated...
JaroslavTulach
commented
Nov 12, 2025
|
|
||
| @Test | ||
| public void loadErrorType() { | ||
| var errorType = EnsoMeta.getType("Standard.Base.Error", "Error"); |
Member
Author
There was a problem hiding this comment.
To debug:
- but breakpoint on line 23
- let your IDE listen to port 5005
- invoke following in the
sbt
sbt:enso> project std-tests
sbt:std-tests> withDebug --debugger testOnly -- *EnsoMetaTest
- does it work for you @jdunkerley, @AdRiley?
4 tasks
JaroslavTulach
added
the
CI: Keep up to date
JaroslavTulach
removed
the
CI: Keep up to date
Akirathan
requested changes
Nov 13, 2025
Member
There was a problem hiding this comment.
What is the difference between std-tests and runtime-integration-tests? In runtime-integration-tests, we are already doing from Standard.Base import all, for example in VectorSortTest. Why yet another project?
EDIT: std-tests uses stuff from std-base. That is the difference.
Akirathan
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Standard.Googlein dual JVM mode #14040 indicatesstd-bitsto be tested with@Rule ContextUtilsChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,