SQL Server Schema support and fix for Generic JDBC (#14032)

- Fix issue with `Database.connect` and Generic JDBC.
- Move `make_table_for_name` and `make_table_from_query` to `SQL_Query` allowing expansion.
- Add `schema` to `SQL_IR_From_Part.Table`.
- Add alternative authentication to SQL Server.
- Fix schema and table listing in SQL Server.

Author: jdunkerley

CHANGELOG.md

@@ -25,9 +25,11 @@
 - [Implement `Text_Column` for in-memory backend.][13769]
 - [Implement `Text_Column.to_case` for in-memory backend.][13769]
 - [Add support for gzip encoded return from web APIs][14026]
+- [Fixes for JDBC connection and schema support for SQL Server.][14039]
 
 [13769]: https://github.com/enso-org/enso/pull/13769
 [14026]: https://github.com/enso-org/enso/pull/14026
+[14039]: https://github.com/enso-org/enso/pull/14039
 
 #### Enso Language & Runtime
 

distribution/lib/Standard/AWS/0.0.0-dev/docs/api/Database/Redshift/Internal/Redshift_Dialect.md

@@ -8,7 +8,7 @@
     - check_aggregate_support self aggregate:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - default_table_types self -> Standard.Base.Any.Any
     - ensure_query_has_no_holes self jdbc:Standard.Database.Internal.JDBC_Connection.JDBC_Connection raw_sql:Standard.Base.Data.Text.Text -> Standard.Base.Any.Any
-    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
+    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any schema_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - flagged self flag:Standard.Database.Dialects.Dialect_Flag.Dialect_Flag -> Standard.Base.Data.Boolean.Boolean
     - generate_collate self collation_name:Standard.Base.Data.Text.Text -> Standard.Base.Data.Text.Text
     - generate_expression self base_gen:Standard.Base.Any.Any expr:(Standard.Database.Internal.IR.SQL_IR_Expression.SQL_IR_Expression|Standard.Database.Internal.IR.Order_Descriptor.Order_Descriptor|Standard.Database.Internal.IR.SQL_IR_Statement.SQL_IR_Statement) for_select:Standard.Base.Data.Boolean.Boolean -> Standard.Database.SQL.SQL_Builder

distribution/lib/Standard/AWS/0.0.0-dev/src/Database/Redshift/Internal/Redshift_Dialect.enso

@@ -301,9 +301,9 @@ type Redshift_Dialect
        ---
        The dialect-dependent strategy to get the Primary Key for a given table.
        Returns `Nothing` if the key is not defined.
-    fetch_primary_key : Connection -> Text -> Vector Text ! Nothing
-    fetch_primary_key self connection table_name =
-        Dialect.default_fetch_primary_key connection table_name
+    fetch_primary_key : Connection -> Text -> Text -> Vector Text ! Nothing
+    fetch_primary_key self connection table_name schema_name =
+        Dialect.default_fetch_primary_key connection table_name schema_name
 
     ## ---
        private: true

distribution/lib/Standard/Database/0.0.0-dev/docs/api/Connection/Connection.md

@@ -18,8 +18,8 @@
     - internal_allocate_dry_run_table self table_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - maybe_run_maintenance self -> Standard.Base.Any.Any
     - new jdbc_connection:Standard.Database.Internal.JDBC_Connection.JDBC_Connection dialect:Standard.Base.Any.Any entity_naming_properties:Standard.Database.Internal.Connection.Entity_Naming_Properties.Entity_Naming_Properties data_link_setup:(Standard.Database.Internal.Data_Link_Setup.Data_Link_Setup|Standard.Base.Nothing.Nothing)= try_large_update:Standard.Base.Data.Boolean.Boolean= -> Standard.Database.Connection.Connection.Connection
-    - query self query:Standard.Database.SQL_Query.SQL_Query alias:Standard.Base.Any.Any= -> Standard.Base.Any.Any
-    - read self query:Standard.Database.SQL_Query.SQL_Query limit:Standard.Table.Rows_To_Read.Rows_To_Read= -> Standard.Base.Any.Any
+    - query self query:Standard.Base.Any.Any alias:Standard.Base.Data.Text.Text= -> Standard.Base.Any.Any
+    - read self query:Standard.Base.Any.Any limit:Standard.Table.Rows_To_Read.Rows_To_Read= -> Standard.Base.Any.Any
     - read_statement self statement:Standard.Base.Any.Any column_types:Standard.Base.Any.Any= last_row_only:Standard.Base.Any.Any= -> Standard.Base.Any.Any
     - read_text_column self query:Standard.Base.Any.Any column_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - save_as_data_link self destination:Standard.Base.Any.Any on_existing_file:Standard.Base.System.File.Existing_File_Behavior.Existing_File_Behavior= -> Standard.Base.Any.Any

distribution/lib/Standard/Database/0.0.0-dev/docs/api/Dialects/Dialect.md

@@ -6,7 +6,7 @@
     - custom_build_aggregate self base_table:Standard.Database.DB_Table.DB_Table key_columns:(Standard.Base.Data.Vector.Vector Standard.Database.Internal.IR.Internal_Column.Internal_Column) resolved_aggregates:(Standard.Base.Data.Vector.Vector Standard.Base.Any.Any) problem_builder:Standard.Table.Internal.Problem_Builder.Problem_Builder -> (Standard.Base.Data.Pair.Pair Standard.Database.Internal.IR.SQL_IR_Source.SQL_IR_Source Standard.Base.Any.Any)
     - default_table_types self -> Standard.Base.Any.Any
     - ensure_query_has_no_holes jdbc:Standard.Database.Internal.JDBC_Connection.JDBC_Connection raw_sql:Standard.Base.Data.Text.Text -> Standard.Base.Any.Any
-    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
+    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any schema_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - flagged self flag:Standard.Database.Dialects.Dialect_Flag.Dialect_Flag -> Standard.Base.Data.Boolean.Boolean
     - generate_collate self collation_name:Standard.Base.Data.Text.Text -> Standard.Base.Data.Text.Text
     - generate_expression self base_gen:Standard.Base.Any.Any expr:(Standard.Database.Internal.IR.SQL_IR_Expression.SQL_IR_Expression|Standard.Database.Internal.IR.Order_Descriptor.Order_Descriptor|Standard.Database.Internal.IR.SQL_IR_Statement.SQL_IR_Statement) for_select:Standard.Base.Data.Boolean.Boolean -> Standard.Database.SQL.SQL_Builder
@@ -33,6 +33,6 @@
 - type Temp_Table_Style
     - Hash_Prefix
     - Temporary_Table
-- default_fetch_primary_key connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
+- default_fetch_primary_key connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any schema_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
 - postgres -> Standard.Base.Any.Any
 - sqlite -> Standard.Base.Any.Any

distribution/lib/Standard/Database/0.0.0-dev/docs/api/Internal/IR/SQL_IR_From_Part.md

@@ -5,7 +5,7 @@
     - Literal_Values column_vectors:(Standard.Base.Data.Vector.Vector Standard.Base.Any.Any) column_names:(Standard.Base.Data.Vector.Vector Standard.Base.Data.Text.Text) alias:Standard.Base.Data.Text.Text
     - Query raw_sql:(Standard.Base.Data.Text.Text|Standard.Database.SQL.SQL_Statement) alias:Standard.Base.Data.Text.Text
     - Sub_Query columns:(Standard.Base.Data.Vector.Vector Standard.Base.Any.Any) context:Standard.Database.Internal.IR.SQL_IR_Source.SQL_IR_Source alias:Standard.Base.Data.Text.Text
-    - Table table_name:Standard.Base.Data.Text.Text alias:Standard.Base.Data.Text.Text internal_temporary_keep_alive_reference:Standard.Base.Any.Any=
+    - Table table_name:Standard.Base.Data.Text.Text schema:Standard.Base.Data.Text.Text alias:Standard.Base.Data.Text.Text internal_temporary_keep_alive_reference:Standard.Base.Any.Any=
     - Union queries:(Standard.Base.Data.Vector.Vector Standard.Database.Internal.IR.SQL_IR_Statement.SQL_IR_Statement) alias:Standard.Base.Data.Text.Text
     - traverse self f:Standard.Base.Any.Any -> Standard.Database.Internal.IR.SQL_IR_From_Part.SQL_IR_From_Part
 - type SQL_IR_From_Part_Comparator

distribution/lib/Standard/Database/0.0.0-dev/docs/api/Internal/IR/SQL_IR_Source.md

@@ -8,7 +8,7 @@
     - as_subquery self alias:Standard.Base.Any.Any column_lists:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - for_query raw_sql:(Standard.Base.Data.Text.Text|Standard.Database.SQL.SQL_Statement) alias:Standard.Base.Data.Text.Text -> Standard.Database.Internal.IR.SQL_IR_Source.SQL_IR_Source
     - for_subquery subquery:Standard.Database.Internal.IR.SQL_IR_From_Part.SQL_IR_From_Part -> Standard.Database.Internal.IR.SQL_IR_Source.SQL_IR_Source
-    - for_table table_name:Standard.Base.Data.Text.Text alias:Standard.Base.Data.Text.Text= internal_temporary_keep_alive_reference:Standard.Base.Any.Any= -> Standard.Base.Any.Any
+    - for_table table_name:Standard.Base.Data.Text.Text schema:Standard.Base.Data.Text.Text alias:Standard.Base.Data.Text.Text= internal_temporary_keep_alive_reference:Standard.Base.Any.Any= -> Standard.Base.Any.Any
     - set_groups self new_groups:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - set_limit self new_limit:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - set_orders self new_orders:Standard.Base.Any.Any -> Standard.Base.Any.Any

distribution/lib/Standard/Database/0.0.0-dev/docs/api/Internal/Postgres/Postgres_Dialect.md

@@ -8,7 +8,7 @@
     - check_aggregate_support self aggregate:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - default_table_types self -> Standard.Base.Any.Any
     - ensure_query_has_no_holes self jdbc:Standard.Database.Internal.JDBC_Connection.JDBC_Connection raw_sql:Standard.Base.Data.Text.Text -> Standard.Base.Any.Any
-    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
+    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any schema_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - flagged self flag:Standard.Database.Dialects.Dialect_Flag.Dialect_Flag -> Standard.Base.Data.Boolean.Boolean
     - generate_collate self collation_name:Standard.Base.Data.Text.Text -> Standard.Base.Data.Text.Text
     - generate_expression self base_gen:Standard.Base.Any.Any expr:(Standard.Database.Internal.IR.SQL_IR_Expression.SQL_IR_Expression|Standard.Database.Internal.IR.Order_Descriptor.Order_Descriptor|Standard.Database.Internal.IR.SQL_IR_Statement.SQL_IR_Statement) for_select:Standard.Base.Data.Boolean.Boolean -> Standard.Database.SQL.SQL_Builder

distribution/lib/Standard/Database/0.0.0-dev/docs/api/Internal/SQLite/SQLite_Dialect.md

@@ -9,7 +9,7 @@
     - custom_build_aggregate self -> Standard.Base.Any.Any
     - default_table_types self -> Standard.Base.Any.Any
     - ensure_query_has_no_holes self jdbc:Standard.Database.Internal.JDBC_Connection.JDBC_Connection raw_sql:Standard.Base.Data.Text.Text -> Standard.Base.Any.Any
-    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
+    - fetch_primary_key self connection:Standard.Base.Any.Any table_name:Standard.Base.Any.Any schema_name:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - flagged self flag:Standard.Database.Dialects.Dialect_Flag.Dialect_Flag -> Standard.Base.Data.Boolean.Boolean
     - generate_collate self collation_name:Standard.Base.Data.Text.Text -> Standard.Base.Data.Text.Text
     - generate_expression self base_gen:Standard.Base.Any.Any expr:(Standard.Database.Internal.IR.SQL_IR_Expression.SQL_IR_Expression|Standard.Database.Internal.IR.Order_Descriptor.Order_Descriptor|Standard.Database.Internal.IR.SQL_IR_Statement.SQL_IR_Statement) for_select:Standard.Base.Data.Boolean.Boolean -> Standard.Database.SQL.SQL_Builder

distribution/lib/Standard/Database/0.0.0-dev/docs/api/SQL_Query.md

@@ -3,4 +3,7 @@
 - type SQL_Query
     - Raw_SQL sql:Standard.Base.Data.Text.Text=
     - Table_Name name:Standard.Base.Data.Text.Text=
+    - to_db_table self connection:Standard.Database.Connection.Connection.Connection alias:Standard.Base.Data.Text.Text -> Standard.Base.Any.Any
+- make_table_for_name connection:Standard.Base.Any.Any name:Standard.Base.Any.Any schema:Standard.Base.Any.Any alias:Standard.Base.Any.Any internal_temporary_keep_alive_reference:Standard.Base.Any.Any= -> Standard.Base.Any.Any
+- make_table_from_query connection:Standard.Base.Any.Any query:(Standard.Base.Data.Text.Text|Standard.Database.SQL.SQL_Statement) alias:Standard.Base.Data.Text.Text -> (Standard.Table.Table.Table&Standard.Database.DB_Table.DB_Table)
 - Standard.Database.SQL_Query.SQL_Query.from that:Standard.Base.Data.Text.Text -> Standard.Database.SQL_Query.SQL_Query