Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Documentation typo #38

Open
ellis2323 opened this issue May 10, 2019 · 2 comments
Open

Documentation typo #38

ellis2323 opened this issue May 10, 2019 · 2 comments

Comments

@ellis2323
Copy link

it is related to this page https://docs.ens.domains/dapp-developer-guide/resolving-names

when you lookup the reverse, you should not compare address with = operator for the ethers library. If you provide lowercase address, it won't work.

You could get the checksum version with:

var address = ethers.utils.getAddress('0x1234...');
@Arachnid
Copy link
Member

Thanks! I've removed that bit entirely, since ethers.js already checks forward resolution internally.

@ellis2323
Copy link
Author

Perfect. I have finished the integration in whois0x.io. Thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants